Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: History is truncated if FeatureFlag.historyImprovementFeatures is turned on #23894

Closed
csadilek opened this issue Feb 22, 2022 · 1 comment
Closed

[Bug]: History is truncated if FeatureFlag.historyImprovementFeatures is turned on #23894

csadilek opened this issue Feb 22, 2022 · 1 comment
Assignees
@rocketsroger
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:History

Comments

@csadilek
Copy link
Contributor

csadilek commented Feb 22, 2022 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open Fenix with profile that has multiple (>5) pages of history visits
  2. Navigate to three dot menu -> History
  3. Scroll down

Expected behaviour

User can scroll and search through entire history.

Actual behaviour

Scrolling only works for up to 5 pages (note that searching works fine.)

Device name

Pixel 3a

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

99

Device logs

No response

Additional information

This only reproduces on Nightly for me, so thinking it's related to the historyImprovementFeatures feature flag.

┆Issue is synchronized with this Jira Task
@csadilek csadilek added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage Feature:History and removed needs:triage Issue needs triage labels Feb 22, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 22, 2022
@csadilek csadilek removed the needs:triage Issue needs triage label Feb 22, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Feb 22, 2022
@rocketsroger
Close mozilla-mobile#23894: Simplify distinct history algorithm
a2bedf7
@mergify mergify bot closed this as completed in c4c263a Feb 24, 2022
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Nightly 2022-03-09 and 99.0.0-Beta.1. The History section can be scrolled to the end even with on longer lists.

Devices used:

  • Huawei MediaPad M3 (Android 7)
  • Google Pixel 6 (Android 12)

pedroldk pushed a commit to pedroldk/fenix that referenced this issue Mar 22, 2022
@rocketsroger @pedroldk
Close mozilla-mobile#23894: Simplify distinct history algorithm
7cb3f72
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:History
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csadilek @rocketsroger @LaurentiuApahideanSV