Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #24495 fix and re-enable settingsPrivacyItemsTest UI test. #24705

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

AndiAJ
Copy link
Collaborator

@AndiAJ AndiAJ commented Apr 11, 2022

For #24495 fix and re-enable settingsPrivacyItemsTest UI test ✅ successfully passed 40x on Firebase

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@AndiAJ AndiAJ force-pushed the settingsPrivacyItemsTest branch 3 times, most recently from 0922b07 to 3d7e79a Compare April 11, 2022 14:11
@AndiAJ AndiAJ changed the title Settings privacy items test For #24495 fix and re-enable settingsPrivacyItemsTest UI test. Apr 11, 2022
@AndiAJ AndiAJ marked this pull request as ready for review April 11, 2022 14:56
@AndiAJ AndiAJ requested review from a team as code owners April 11, 2022 14:56
Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor function rename

@AndiAJ AndiAJ requested a review from AaronMT April 12, 2022 11:47
@AaronMT AaronMT added the pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] label Apr 12, 2022
@mergify mergify bot merged commit 8c42f7f into mozilla-mobile:main Apr 12, 2022
@AndiAJ AndiAJ deleted the settingsPrivacyItemsTest branch April 13, 2022 05:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants