Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove org.mozilla.appservices gradle plugin, perform megazord substitution by hand #2555

Closed
rfk opened this issue May 16, 2019 · 0 comments
Closed

Remove org.mozilla.appservices gradle plugin, perform megazord substitution by hand #2555

rfk opened this issue May 16, 2019 · 0 comments

Comments

@rfk
Copy link
Contributor

rfk commented May 16, 2019 •
edited by data-sync-user
Loading

As discussed in mozilla/application-services#1097 the Application Services team would like to deprecate our special "megazording" gradle plugin, because it's complex to maintain and seems to interfere with other gradle features such as composite builds.

@ncalexan posted a proof-of-concept PR for how we might remove it and instead perform the megazord substitution by hand here:

#1787

I've been poking at different variants of the approach and will put up a replacement PR shortly.

┆Issue is synchronized with this Jira Task
@rfk rfk mentioned this issue May 16, 2019
Closed
rfk added a commit to rfk/fenix that referenced this issue May 16, 2019
@rfk
Closed mozilla-mobile#2555: Remove appservices gradle plugin, perform…
d33b1d4 
… megazord substitution by hand.
rfk added a commit to rfk/fenix that referenced this issue May 16, 2019
@rfk
Closes mozilla-mobile#2555: Remove appservices gradle plugin, perform…
154e51d 
… megazord substitution by hand.
rfk added a commit to rfk/fenix that referenced this issue May 16, 2019
@rfk
Closes mozilla-mobile#2555: Remove appservices gradle plugin, perform…
49d171f 
… megazord substitution by hand.
rfk added a commit to rfk/fenix that referenced this issue May 16, 2019
@rfk
Closes mozilla-mobile#2555: Remove appservices gradle plugin, perform…
2a5a6ce 
… megazord substitution by hand.
@rfk rfk mentioned this issue May 16, 2019
Merged
4 tasks
rfk added a commit to rfk/fenix that referenced this issue May 20, 2019
@rfk
Closes mozilla-mobile#2555: Remove appservices gradle plugin, perform…
dc1c6c6 
… megazord substitution by hand.
rfk added a commit to rfk/fenix that referenced this issue May 23, 2019
@rfk
Closes mozilla-mobile#2555: Remove appservices gradle plugin, perform…
af4b0c6 
… megazord substitution by hand.
@boek boek closed this as completed in 17f8e23 May 23, 2019
@data-sync-user data-sync-user changed the title Remove org.mozilla.appservices gradle plugin, perform megazord substitution by hand FNX2-18073 ⁃ Remove org.mozilla.appservices gradle plugin, perform megazord substitution by hand Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18073 ⁃ Remove org.mozilla.appservices gradle plugin, perform megazord substitution by hand FNX3-16406 ⁃ Remove org.mozilla.appservices gradle plugin, perform megazord substitution by hand Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX3-16406 ⁃ Remove org.mozilla.appservices gradle plugin, perform megazord substitution by hand Remove org.mozilla.appservices gradle plugin, perform megazord substitution by hand Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rfk @kbrosnan @data-sync-user