Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Floating content on custom tab bottom #2561

Closed
Amejia481 opened this issue May 16, 2019 · 4 comments
Closed

[Bug] Floating content on custom tab bottom #2561

Amejia481 opened this issue May 16, 2019 · 4 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:CustomTabs Release Blocker Blocks a Release
Milestone
Sprint 5-2 (Miles...

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented May 16, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open this site in custom tab.

Expected behavior

The content is floating

Actual behavior

The content shouldn't be floating

ScreenshotUNITO-UNDERSCORE!20190516-071952!

Device information

  • Android device: Pixel 3

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added 🐞 bug Crashes, Something isn't working, .. Feature:CustomTabs labels May 16, 2019
@Amejia481
Copy link
Contributor Author

After this commit, we added dynamically additional space between the bottom toolbar and content in normal browsing but is affecting the custom tab.

@ekager ekager self-assigned this May 16, 2019
ekager added a commit to ekager/fenix that referenced this issue May 16, 2019
@ekager
For mozilla-mobile#2561 - Dynamically set EngineView behavior in Brow…
2b9a091 
…serFragment
ekager added a commit that referenced this issue May 16, 2019
@ekager
For #2561 - Dynamically set EngineView behavior in BrowserFragment
43843b0
@vesta0 vesta0 added this to the Bugs milestone May 16, 2019
@vesta0
Copy link
Collaborator

vesta0 commented May 16, 2019

@ekager let's hold off on this one for now

@ekager
Copy link
Contributor

ekager commented May 16, 2019

@vesta0 it's already been fixed :)

@vesta0 vesta0 added the eng:qa:needed QA Needed label May 16, 2019
@vesta0 vesta0 modified the milestones: Bugs, Sprint 5-2 (Milestone 5) May 16, 2019
@bifleming bifleming added the Release Blocker Blocks a Release label May 17, 2019
@lobontiumira
Copy link

Verified as fixed on the latest build 1.0.1920 (#11391807), with Sony Xperia Z5 Premium (Android 7.1.1), and Samsung Galaxy Note 8 (Android 9).

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 20, 2019
@data-sync-user data-sync-user changed the title [Bug] Floating content on custom tab bottom FNX2-18078 ⁃ [Bug] Floating content on custom tab bottom Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18078 ⁃ [Bug] Floating content on custom tab bottom FNX3-16411 ⁃ [Bug] Floating content on custom tab bottom Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16411 ⁃ [Bug] Floating content on custom tab bottom [Bug] Floating content on custom tab bottom May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:CustomTabs Release Blocker Blocks a Release
Projects
None yet
Milestone
Sprint 5-2 (Milestone 5)
Development

No branches or pull requests
8 participants
@Amejia481 @NotWoods @sv-ohorvath @ekager @lobontiumira @vesta0 @bifleming @data-sync-user