Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: "Remove" button from the last synced tab from jump back in doesn't work when the cursor in the search bar is active #26690

Closed
SoftVision-LorandJanos opened this issue Aug 29, 2022 · 3 comments · Fixed by #26789, fork-house/fenix#13, nathanmkaya/fenix#108, C-EO/fenix#4 or fork-house/fenix#14
Closed

[Bug]: "Remove" button from the last synced tab from jump back in doesn't work when the cursor in the search bar is active #26690

SoftVision-LorandJanos opened this issue Aug 29, 2022 · 3 comments · Fixed by #26789, fork-house/fenix#13, nathanmkaya/fenix#108, C-EO/fenix#4 or fork-house/fenix#14
Assignees
@Alexandru2909
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:RecentTabs Recent tabs on the homescreen needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Milestone
106

Comments

@SoftVision-LorandJanos
Copy link

SoftVision-LorandJanos commented Aug 29, 2022 •
edited by data-sync-user

Steps to reproduce

  1. On a mobile device login in with a Firefox account.
  2. On a second device login with the same account and open at least 1 tab.
  3. Perform a sync.
  4. On the mobile homescreen go to the jump back in section and long tap on the last synced tab while the cursor from the search bar is active.
  5. Tap on "Remove".

Expected behaviour

The tab is removed. The remove button is no longer displayed.

Actual behaviour

The "Remove" button doesn't work.

Device name

Oppo Find X5

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

106.0a1

Device logs

No response

Additional information

20220829_163526.mp4

The button works as expected when the cursor is not active.

┆Issue is synchronized with this Jira Task
@SoftVision-LorandJanos SoftVision-LorandJanos added 🐞 bug Crashes, Something isn't working, .. S3 Blocks non-critical functionality and a work around exists needs:triage Issue needs triage Feature:RecentTabs Recent tabs on the homescreen TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368 labels Aug 29, 2022
@Alexandru2909 Alexandru2909 self-assigned this Aug 29, 2022
@Alexandru2909
Copy link
Contributor

There seems to be a problem with dispatching the touch event to the Popup elements from SearchDialogFragment to HomeFragment. This makes the user unable to interact with any of the popups from the homescreen.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Sep 2, 2022
For mozilla-mobile#26690 - Dismiss search dialog when opening recent …
58b1094 
…synced tab dropdown menu
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 2, 2022
@github-actions github-actions bot mentioned this issue Sep 2, 2022
Merged
4 tasks
@Alexandru2909 Alexandru2909 mentioned this issue Sep 2, 2022
Closed
@Alexandru2909
Copy link
Contributor

The issue is still persistent for other elements of the homescreen (Recent tabs, Recently visited, Recently saved). Filed #26790 for this.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Sep 6, 2022
For mozilla-mobile#26690 - Dismiss search dialog when opening recent …
da009bd 
…synced tab dropdown menu
@Alexandru2909 Alexandru2909 mentioned this issue Sep 7, 2022
Closed
Mugurell pushed a commit to Alexandru2909/fenix that referenced this issue Sep 14, 2022
@Mugurell
For mozilla-mobile#26690 - Dismiss search dialog when opening recent …
02d6059 
…synced tab dropdown menu
@AdinaPetridean AdinaPetridean mentioned this issue Sep 14, 2022
Closed
@mergify mergify bot closed this as completed in #26789 Sep 14, 2022
mergify bot pushed a commit that referenced this issue Sep 14, 2022
@mergify
For #26690 - Dismiss search dialog when opening recent synced tab dro…
bda817a 
…pdown menu
@github-actions github-actions bot reopened this Sep 14, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 14, 2022
@github-actions github-actions bot added this to the 106 milestone Sep 14, 2022
@delia-pop delia-pop mentioned this issue Sep 14, 2022
Closed
@SoftVision-LorandJanos
Copy link
Author

This issue is no longer reproducible on the latest Nightly 106.0a1 (2022-09-14T17...) build.
The cursor is dismissed when popup is displayed.
Device used: google Pixel 4 (Android 12).
Closing the ticket as verified.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 15, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 3, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
881031d 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 5, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
0f8a05e 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 11, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
505f3a1 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 11, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
317797f 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 12, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
f4d08e7 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 12, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
ef68cc4 
… recent synced tab dropdown menu"

This reverts commit bda817a.
This was referenced Oct 18, 2022
Merged
Merged
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 24, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
cebe254 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 26, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
913c8ae 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Nov 15, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
7484adb 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Nov 16, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
55eedba 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Dec 6, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
a900bf1 
… recent synced tab dropdown menu"

This reverts commit bda817a.
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Dec 13, 2022
Revert "For mozilla-mobile#26690 - Dismiss search dialog when opening…
9813cc0 
… recent synced tab dropdown menu"

This reverts commit bda817a.
mergify bot added a commit that referenced this issue Dec 13, 2022
@mergify
For #26957 - Exit search dialog when interacting with home fragment (#…
4ee62dd 
…27262)

* Revert "For #26790 - Dismiss search dialog when opening recent bookmark dropdown menu"

This reverts commit 262aa16.

* Revert "For #26790 - Dismiss search dialog when opening recent visit dropdown menu"

This reverts commit b93b085

* Revert "For #26790 - Dismiss search dialog when opening recent tab dropdown menu"

This reverts commit 44b71bb.

* Revert "For #26690 - Dismiss search dialog when opening recent synced tab dropdown menu"

This reverts commit bda817a.

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen top sites

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen collection

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen recent visits

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen recent tabs

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen recent bookmarks

* For #26957 - Remove code to dismiss search dialog when interacting with pocket stories

* For #26957 - Dismiss search dialog when interacting with home fragment

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This was referenced Jan 21, 2023
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mergify
[fenix] For mozilla-mobile/fenix#26690 - Dismiss search dialog when o…
86d44a4 
…pening recent synced tab dropdown menu
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mergify
[fenix] For mozilla-mobile/fenix#26957 - Exit search dialog when inte…
0be80dd 
…racting with home fragment (mozilla-mobile/fenix#27262)

* Revert "For mozilla-mobile/fenix#26790 - Dismiss search dialog when opening recent bookmark dropdown menu"

This reverts commit 5caee27.

* Revert "For mozilla-mobile/fenix#26790 - Dismiss search dialog when opening recent visit dropdown menu"

This reverts commit b2af04c

* Revert "For mozilla-mobile/fenix#26790 - Dismiss search dialog when opening recent tab dropdown menu"

This reverts commit bfdf6d2.

* Revert "For mozilla-mobile/fenix#26690 - Dismiss search dialog when opening recent synced tab dropdown menu"

This reverts commit 86d44a4.

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen top sites

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen collection

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen recent visits

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen recent tabs

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen recent bookmarks

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with pocket stories

* For mozilla-mobile/fenix#26957 - Dismiss search dialog when interacting with home fragment

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Alexandru2909 Alexandru2909

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:RecentTabs Recent tabs on the homescreen needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Projects
None yet
Milestone
106
2 participants
@Alexandru2909 @SoftVision-LorandJanos