[Bug]: The Tab pickup CFR cannot be dismissed while the search bar is active

[AdinaPetridean]

Prerequisites:

On Desktop or another mobile device visit some webpages making sure you are signed in with the same account.

Steps to reproduce

1. Perform a clear data and launch the Firefox application.
2. From the "Pick up where you left" section tap on Sign in button and sign in with the same account.
3. Dismiss the Onboarding.
4. While the search bar is active, scroll up.
5. Once the Synced tabs section is displayed, tap outside the "Your tabs are syncing! Pick up where you left off on your other device" message or tap the "X" button from the CFR.
6. Observe the behavior.

Expected behaviour

The Tab pickup CFR is dismissed when tapping outside the prompt or when tapping the "X" button.

Actual behaviour

The Tab pickup CFR cannot be dismissed by tapping outside the prompt or when tapping the "X" button while the search bar is active.

Device name

OnePlus 9 Pro

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

Firefox Nightly 106.0a1 - 09/13

Device logs

No response

Additional information

Please note this issue is also reproducible with Poco M4 Pro (Android 12), Xiaomi Pad5 (Android 11) and other devices.

Screenrecorder-2022-09-14-13-04-03-758_Trim.mp4

CFR.mp4

┆Issue is synchronized with this Jira Task

[delia-pop]

Using Lenovo Yoga Tab 11 (Android 11) I was only able to reproduce this issue using different STR:

1. Perform clear data and launch Fenix.
2. Tap the "Read our policy" button from "You control your data" card.
3. Tap the back button on the device to return to the Onboarding Tour.
4. Tap the "Sign in" button from "Pick up where you left off" card.
5. Sign in with the same account you are already signed in on Desktop (I used the QR code scan).
6. After signing in wait several seconds (~15s) before dismissing the Onboarding.
7. Dismiss the keyboard but leave the search dialog active and scroll up to see the "Jump back in" section.

After Step 7, both the Privacy policy tab previously opened and the Synced tab were displayed under the "Jump back in" section and also the Tab Pickup CFR. The CFR could not be dismiss by tapping outside de prompt until the user started scrolling down.

TabPickupCFR.mp4

[delia-pop]

Upon further testing we noticed that this issue is caused by the active search bar, as it is not reproducible when the search dialog is not active. We updated the STR accordingly.
We discussed this with @Mugurell and he explained that the fix for #26690 might not solve the CFR dismissal issue as it is.

[Mugurell]

The fix for #26690 solves that specific scenario while this seems like another one related.
To fix this bug and maybe others I think we have to address the common cause - the toolbar remaining in edit mode and so it having focus and not the homescreen content.
So an easy fix would be to exit edit mode when the keyboard is hidden.

[cpeterso]

When the CFR can't be dismissed, can the user still use the search bar and the rest of the app? Or is the whole app stuck?

If the user can still use the search bar, then this bug is a lower priority and doesn't need to be fixed in MR v106.

If the whole app is stuck, then this bug is a high priority for MR v106. For any MR bug fixes to be included in the v106 release, they should be uplifted (and landed in the beta branch) by end of day 2022-09-30.

[Mugurell]

This bug affects all popups showing on screen - other CFRs or menus appearing after the toolbar is in edit mode and stems from the toolbar intercepting all touch events and sending them to the homescreen fragment while the popups are shown in a different window on top of homescreen.
The issue is encountered with the "Tab pickup CFR" because there's an inherent delay to download and show the synced tab and it is possible for it (and the CFR) to be shown after the user already interacted with the toolbar and left it in edit mode.
Users can still interact with the app - enter an URL to visit or tap the other buttons from the toolbar - first touch will dismiss the CFR.

TabPickupCFR.mp4

[Mugurell]

The bigger issue with the toolbar intercepting touch events was half-way avoided - just for the menus in #26832.
To fix it for CFRs also (and simplify the code a bit by not having to account for different touch scenarios) we could make a decision to not leave the toolbar in edit mode when the homescreen is shown.
The above PR shows how this works when long pressing on items that shows the "Remove" menu. We'd do that by default.

[Mugurell]

From @cpeterso

Sounds like we don't need to rush a fix for 106 but we should clean up this code (like your suggestion to exit edit mode when the keyboard is closed).

[AdinaPetridean]

While retesting this issue on OnePlus 9 Pro (Android 12) the following behaviour was observed:
When the user taps outside, the Tab Pickup CFR is dismissed only after the second attempt (after the 1st tap the search bar becomes inactive; after the 2nd tap, the CFR is dismissed)

Is the first tap expected?

Please observe the attached video.

dismiss_by_tapping_outisde.mp4

@Alexandru2909

[Alexandru2909]

Hi @AdinaPetridean, thanks for testing this! I'm working on a fix for the issue described in your comment.

[delia-pop]

Verified as fixed on the latest Nightly 110.0a1 from 12/24 with OPPO A15s (Android 10). The Jump back in and Tab Pickup CFRs can now be dismissed.
The behavior described in the comment above is intended: the first tap (or attempt to swipe on screen will make the search bar inactive, and the 2nd tap on screen will dismiss the CFR).