This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Dismiss search dialog when interacting with popups from homescreen #26790

Closed

Alexandru2909 opened this issue Sep 2, 2022 · 1 comment · Fixed by #26832, fork-house/fenix#13, nathanmkaya/fenix#108, C-EO/fenix#4 or fork-house/fenix#14

Assignees

Labels

eng:qa:verified eng:tech-debt

Milestone

Contributor

Alexandru2909 commented Sep 2, 2022 •

edited by data-sync-user

In #26690 we noticed that the user could not interact with the remove dropdown for recent synced tabs from the homescreen when SearchDialog was displayed. This is still an issue with other homescreen sections which support popups or dropdown menus: Recent tabs, Recently visited, Recently saved.

┆Issue is synchronized with this Jira Task

The text was updated successfully, but these errors were encountered:

Alexandru2909 added the eng:tech-debt label

Alexandru2909 mentioned this issue

[Bug]: "Remove" button from the last synced tab from jump back in doesn't work when the cursor in the search bar is active #26690

Closed

github-actions bot added the needs:triage label

Alexandru2909 removed the needs:triage label

Alexandru2909 self-assigned this

Alexandru2909 mentioned this issue

For #26690 - Dismiss search dialog when opening recent synced tab dropdown menu #26789

Merged

4 tasks

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

36f68e1

…tab dropdown menu

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

a0c519e

…visit dropdown menu

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

3359de0

…bookmark dropdown menu

github-actions bot mentioned this issue

For #26790 - Dismiss search dialog when interacting with popups from homescreen #26832

Merged

4 tasks

github-actions bot added the eng:reopen-for-qa label

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

9c1d0f9

…tab dropdown menu

For mozilla-mobile#26790 -  recent tab

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

5cf9bde

…visit dropdown menu

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

6eba552

…bookmark dropdown menu

Mugurell pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

20d536a

…tab dropdown menu

For mozilla-mobile#26790 -  recent tab

Mugurell pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

cb7eb89

…visit dropdown menu

Mugurell pushed a commit to Alexandru2909/fenix that referenced this issue


          For mozilla-mobile#26790 - Dismiss search dialog when opening recent …

4f6c075

…bookmark dropdown menu

mergify bot closed this as completed in #26832

mergify bot pushed a commit that referenced this issue


          For #26790 - Dismiss search dialog when opening recent tab dropdown menu

44b71bb

For #26790 -  recent tab

mergify bot pushed a commit that referenced this issue


          For #26790 - Dismiss search dialog when opening recent visit dropdown…

b93b085

… menu

mergify bot pushed a commit that referenced this issue


          For #26790 - Dismiss search dialog when opening recent bookmark dropd…

262aa16

…own menu

github-actions bot reopened this

github-actions bot added eng:qa:needed and removed eng:reopen-for-qa labels

github-actions bot added this to the 106 milestone

SoftVision-LorandJanos commented Sep 15, 2022

Verified as fixed on the latest Nightly 106.0a1 (2022-09-14T17...) build.
Device used: google Pixel 4 (Android 12).
Closing the ticket as verified.

SoftVision-LorandJanos closed this as completed

SoftVision-LorandJanos added eng:qa:verified and removed eng:qa:needed labels

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

9bfb0ac

… recent bookmark dropdown menu"

This reverts commit 262aa16.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

e159bb2

… recent bookmark dropdown menu"

This reverts commit 262aa16.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

af86611

… recent visit dropdown menu"

This reverts commit b93b085.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

51d9c9b

… recent tab dropdown menu"

This reverts commit 44b71bb.

This was referenced Oct 17, 2022

[pull] main from mozilla-mobile:main fork-house/fenix#13

Merged

[pull] main from mozilla-mobile:main nathanmkaya/fenix#108

Merged

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

3349e1f

… recent bookmark dropdown menu"

This reverts commit 262aa16.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

fb01266

… recent visit dropdown menu"

This reverts commit b93b085.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

76a3f95

… recent tab dropdown menu"

This reverts commit 44b71bb.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

b6e1e4e

… recent bookmark dropdown menu"

This reverts commit 262aa16.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

a5d46da

… recent visit dropdown menu"

This reverts commit b93b085.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

5a131cd

… recent tab dropdown menu"

This reverts commit 44b71bb.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

aac52fb

… recent bookmark dropdown menu"

This reverts commit 262aa16.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

3d8fbe4

… recent visit dropdown menu"

This reverts commit b93b085

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

64571cf

… recent tab dropdown menu"

This reverts commit 44b71bb.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

3a386a1

… recent bookmark dropdown menu"

This reverts commit 262aa16.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

cbb220a

… recent visit dropdown menu"

This reverts commit b93b085

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

30bc058

… recent tab dropdown menu"

This reverts commit 44b71bb.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

c46fb64

… recent bookmark dropdown menu"

This reverts commit 262aa16.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

0ddb920

… recent visit dropdown menu"

This reverts commit b93b085

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

4f4f98d

… recent tab dropdown menu"

This reverts commit 44b71bb.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

6c368e5

… recent bookmark dropdown menu"

This reverts commit 262aa16.

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

7a5fdbc

… recent visit dropdown menu"

This reverts commit b93b085

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue


          Revert "For mozilla-mobile#26790 - Dismiss search dialog when opening…

7607e4b

… recent tab dropdown menu"

This reverts commit 44b71bb.

mergify bot added a commit that referenced this issue


          For #26957 - Exit search dialog when interacting with home fragment (#…

4ee62dd

…27262)

* Revert "For #26790 - Dismiss search dialog when opening recent bookmark dropdown menu"

This reverts commit 262aa16.

* Revert "For #26790 - Dismiss search dialog when opening recent visit dropdown menu"

This reverts commit b93b085

* Revert "For #26790 - Dismiss search dialog when opening recent tab dropdown menu"

This reverts commit 44b71bb.

* Revert "For #26690 - Dismiss search dialog when opening recent synced tab dropdown menu"

This reverts commit bda817a.

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen top sites

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen collection

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen recent visits

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen recent tabs

* For #26957 - Remove code to dismiss search dialog when interacting with homescreen recent bookmarks

* For #26957 - Remove code to dismiss search dialog when interacting with pocket stories

* For #26957 - Dismiss search dialog when interacting with home fragment

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

This was referenced Jan 21, 2023

[pull] main from mozilla-mobile:main C-EO/fenix#4

Merged

[pull] main from mozilla-mobile:main fork-house/fenix#14

Merged

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue


          [fenix] For mozilla-mobile/fenix#26790 - Dismiss search dialog when o…

b2af04c

…pening recent visit dropdown menu

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue


          [fenix] For mozilla-mobile/fenix#26790 - Dismiss search dialog when o…

5caee27

…pening recent bookmark dropdown menu

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue


          [fenix] For mozilla-mobile/fenix#26957 - Exit search dialog when inte…

0be80dd

…racting with home fragment (mozilla-mobile/fenix#27262)

* Revert "For mozilla-mobile/fenix#26790 - Dismiss search dialog when opening recent bookmark dropdown menu"

This reverts commit 5caee27.

* Revert "For mozilla-mobile/fenix#26790 - Dismiss search dialog when opening recent visit dropdown menu"

This reverts commit b2af04c

* Revert "For mozilla-mobile/fenix#26790 - Dismiss search dialog when opening recent tab dropdown menu"

This reverts commit bfdf6d2.

* Revert "For mozilla-mobile/fenix#26690 - Dismiss search dialog when opening recent synced tab dropdown menu"

This reverts commit 86d44a4.

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen top sites

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen collection

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen recent visits

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen recent tabs

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with homescreen recent bookmarks

* For mozilla-mobile/fenix#26957 - Remove code to dismiss search dialog when interacting with pocket stories

* For mozilla-mobile/fenix#26957 - Dismiss search dialog when interacting with home fragment

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue


          [fenix] For mozilla-mobile/fenix#26790 - Dismiss search dialog when o…

bfdf6d2

…pening recent tab dropdown menu

For mozilla-mobile/fenix#26790 -  recent tab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.