Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] favicons should have smaller corner radius #3268

Closed
myakura opened this issue Jun 7, 2019 · 4 comments
Closed

[Bug] favicons should have smaller corner radius #3268

myakura opened this issue Jun 7, 2019 · 4 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. Feature:HomeScreen Feature:Tabs good first issue Good for newcomers needs:UX-feedback Needs UX Feedback
Milestone

Comments

@myakura
Copy link

myakura commented Jun 7, 2019

Steps to reproduce

  1. open sites
  2. look at the selected tab in the "open tabs" section in the home view

Expected behavior

favicons have slightly smaller corner radius than the ones of outer box so that outer borders or inner negative space do not make thicker edges.

I cannot explain it well... these article should help understanding what I mean:

Actual behavior

screenshot

it seems favicons have the same or larger corner radius.

Device information

  • Android device: Xiaomi Mi A1
  • Fenix version: 1.0.1923

┆Issue is synchronized with this Jira Task

@myakura myakura added the 🐞 bug Crashes, Something isn't working, .. label Jun 7, 2019
@ekager
Copy link
Contributor

ekager commented Jun 8, 2019

I agree this looks a bit strange. For reference here I have made it favIconBorderRadiusInPx cut in half to 4.

127877

@myakura
Copy link
Author

myakura commented Jun 8, 2019

@ekager that looks great!

@sblatz sblatz added the good first issue Good for newcomers label Jun 21, 2019
@mheubusch
Copy link
Contributor

@AmyYLee can you review and approve this approach? If you are ok with it can you remove the Needs UX label and add the Ready for Eng label?

@AmyYLee
Copy link
Collaborator

AmyYLee commented Jul 2, 2019

@AmyYLee can you review and approve this approach? If you are ok with it can you remove the Needs UX label and add the Ready for Eng label?

This looks good to me. @mheubusch

ekager added a commit to ekager/fenix that referenced this issue Jul 2, 2019
@sblatz sblatz closed this as completed in 99209aa Jul 2, 2019
@colintheshots colintheshots added this to the v1.1 milestone Jul 23, 2019
@data-sync-user data-sync-user changed the title [Bug] favicons should have smaller corner radius FNX3-16902 ⁃ [Bug] favicons should have smaller corner radius Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16902 ⁃ [Bug] favicons should have smaller corner radius [Bug] favicons should have smaller corner radius May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:HomeScreen Feature:Tabs good first issue Good for newcomers needs:UX-feedback Needs UX Feedback
Projects
None yet
Development

No branches or pull requests

9 participants