Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Autoplay icon is black in dark theme #5474

Closed
neekless opened this issue Sep 21, 2019 · 3 comments
Closed

[Bug] Autoplay icon is black in dark theme #5474

neekless opened this issue Sep 21, 2019 · 3 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering good first issue Good for newcomers Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue.
Milestone
v2.1

Comments

@neekless
Copy link
Contributor

neekless commented Sep 21, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Use dark theme
  2. Go to site permissions

Expected behavior

Autoplay icon color should adapt: black on light theme, white on dark theme

Actual behavior

Screenshot_20190922-013745

Device information

  • Android device: Pixel 2xl Android 9
  • Fenix version:
    Nightly 190920 18:01 (Build #12631814)
    📦: 14.0.0, 3a0651992
    🦎: 71.0a1-20190919094654

┆Issue is synchronized with this Jira Task
@neekless neekless added the 🐞 bug Crashes, Something isn't working, .. label Sep 21, 2019
@ekager ekager added eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. good first issue Good for newcomers labels Sep 21, 2019
@NotWoods NotWoods added the Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! label Sep 21, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 23, 2019

Reproducible on Nightly build #12651809 from 22/9 using the following devices:
• Google Pixel 3a (Android 9)
• Samsung Galaxy Note 9 (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

ekager pushed a commit that referenced this issue Sep 23, 2019
@neekless @ekager
For #5474 - Adapt Autoplay icon to theme
72eed21
@ekager ekager added the eng:qa:needed QA Needed label Sep 23, 2019
@neekless
Copy link
Contributor Author

Fixed in Nightly 190923 18:00 (Build #12661830)
Screenshot_20190924-090742
Screenshot_20190924-090749

@sv-ohorvath
Copy link
Contributor

Verified as fixed on Nightly 9/23. Devices: Pixel 3 (Android 9), Mi 4i (Android 5.0.2)

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 24, 2019
@sblatz sblatz added this to the v2.1 milestone Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering good first issue Good for newcomers Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
6 participants
@NotWoods @sv-ohorvath @sblatz @neekless @ekager @AndiAJ