Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Download Completed Notification is too intrusive #9044

Closed
s-ankur opened this issue Mar 8, 2020 · 8 comments
Closed

[Bug] Download Completed Notification is too intrusive #9044

s-ankur opened this issue Mar 8, 2020 · 8 comments
Assignees
@codrut-topliceanu
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Download needs:triage Issue needs triage

Comments

@s-ankur
Copy link
Contributor

s-ankur commented Mar 8, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

Download any file

Expected behavior

Small nonintrusive notification appears. It does not affect browsing in any way and user can continue to do what they were doing before .Notification automatically disabled after a while or after interaction with the webpage.

Actual behavior

Large notification and dark screen intruding on usability especially if you plan to download many images continuosly

Device information

  • Android device: Asus Zenfone
  • Fenix version: Fenix Nightly

┆Issue is synchronized with this Jira Task
@s-ankur s-ankur added the 🐞 bug Crashes, Something isn't working, .. label Mar 8, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 8, 2020
@test2a
Copy link

test2a commented Mar 9, 2020

Yes. Came here to say this. The popup should fade away say after 2 seconds like it does on ff proper

@liuche
Copy link
Contributor

liuche commented Apr 1, 2020

cc-ing @brampitoyo here from UX, if you want to address these. Our snackbars tend to be standardized, so may also just be something we won't plan to address.

@brampitoyo
Copy link

@s-ankur @test2a I agree with part of your proposal.

Agree. Our dialog is currently blocking you from doing any other action until you dismiss it (tap “x”). We should make this dialog non-blocking. In other words, let’s not show any scrim. This way, you’d be able to select, scroll, long-press, etc. on the site. You can proceed downloading the next file, or perform any other action.

Disagree. We shouldn’t change the form of our dialog. It shouldn’t be a snackbar that fades away after 2 seconds. What if you want to view the image later on, but not right after it finishes downloading? The only way to do this would be to swipe down to the Notification Centre, then select the downloaded file – not impossible, but inconvenient. By keeping the notification as a non-blocking dialogue, you can easily open the file, dismiss it, or continue doing your current task.

Thoughts?

@brampitoyo brampitoyo self-assigned this Apr 2, 2020
@brampitoyo brampitoyo added the needs:UX-feedback Needs UX Feedback label Apr 2, 2020
@s-ankur
Copy link
Contributor Author

s-ankur commented Apr 2, 2020 •
edited
Loading

Yeah I agree. Non blocking is whats really important to me, since it really affects the ability to download things in quick succession. But also I would definitely prefer if the dialog takes up less screen-space.

Secondly, the dialog disappearing by itself would really be counterproductive, as you point out. What I can suggest is that instead of it being on a timeout, you could have it be dynamic, like the dynamic addressbar that we have now. At least that is the way chrome does it, and it does feel a lot less intrusive that way.

@brampitoyo
Copy link

@s-ankur Sounds good. Here’s an updated “Download completed” notification that’s non-interruptive.

@brampitoyo brampitoyo removed their assignment Apr 6, 2020
@brampitoyo brampitoyo added eng:ready Ready for engineering needs:triage Issue needs triage and removed needs:UX-feedback Needs UX Feedback needs:triage Issue needs triage labels Apr 6, 2020
@codrut-topliceanu codrut-topliceanu self-assigned this Apr 7, 2020
@codrut-topliceanu codrut-topliceanu mentioned this issue May 7, 2020
Closed
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 7, 2020
For mozilla-mobile#9044 - Replace DownloadNotificationBottomSheetDial…
5caf9a3 
…og with unobtrusive view
@codrut-topliceanu codrut-topliceanu mentioned this issue May 7, 2020
Merged
4 tasks
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 19, 2020
For mozilla-mobile#9044 - Replace DownloadNotificationBottomSheetDial…
8887f9c 
…og with unobtrusive view
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 19, 2020
For mozilla-mobile#9044 - Renamed DownloadNotification and removed Do…
c2083d8 
…wnloadState.dismissed dependency
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 19, 2020
For mozilla-mobile#9044 - Improved DynamicDownloadDialog behaviour wh…
6c9b5b7 
…en scrolling
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 19, 2020
For mozilla-mobile#9044 - DynamicDownloadDialog remains attached to t…
3f7fc2c 
…ab until dismissed
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 19, 2020
For mozilla-mobile#9044 - Fix onTryAgain not working for resumed Down…
1e005fd 
…loadDialogs
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 19, 2020
For mozilla-mobile#9044 - Fix onTryAgain not working for resumed Down…
cb7ebaa 
…loadDialogs
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 19, 2020
For mozilla-mobile#9044 - Replace DownloadNotificationBottomSheetDial…
fe82d63 
…og with unobtrusive view

- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue May 21, 2020
For mozilla-mobile#9044 - Replace DownloadNotificationBottomSheetDial…
f4596b4 
…og with unobtrusive view

- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
Amejia481 pushed a commit that referenced this issue May 21, 2020
@Amejia481
For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtr…
7feae98 
…usive view

- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
@codrut-topliceanu codrut-topliceanu mentioned this issue Jun 9, 2020
Closed
@codrut-topliceanu codrut-topliceanu added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jun 9, 2020
@codrut-topliceanu
Copy link
Contributor

codrut-topliceanu commented Jun 9, 2020 •
edited
Loading

Changes from mozilla-mobile/android-components#7050 have made the fix for this unstable at the moment. Anyone willing to test this issue would need to get hold of a build just after PR #10491 was merged.

I will open a new issue where the new problems can be solved, after 7050 is done.

@codrut-topliceanu codrut-topliceanu removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jun 9, 2020
@liuche liuche mentioned this issue Jun 10, 2020
Closed
29 tasks
@codrut-topliceanu codrut-topliceanu mentioned this issue Jun 12, 2020
Closed
@codrut-topliceanu
Copy link
Contributor

Will be fixed by #11371

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 19, 2020

Hi, verified as fixed on the latest Nightly Build #200619 from 6/19 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200619-145000

@AndiAJ AndiAJ closed this as completed Jun 19, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 19, 2020
@codrut-topliceanu codrut-topliceanu mentioned this issue Sep 21, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codrut-topliceanu codrut-topliceanu

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Download needs:triage Issue needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@brampitoyo @liuche @kglazko @s-ankur @test2a @AndiAJ @codrut-topliceanu