Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y] Error Page-Touch target-"Deceptive site issue" page "Go back" button's height needs to be increased #9771

Closed
Diana-Rus opened this issue Apr 7, 2020 · 1 comment
Closed

[Bug][a11y] Error Page-Touch target-"Deceptive site issue" page "Go back" button's height needs to be increased #9771

Diana-Rus opened this issue Apr 7, 2020 · 1 comment
Assignees
@mcarare
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:ErrorMessages P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@Diana-Rus
Copy link

Diana-Rus commented Apr 7, 2020 •
edited by data-sync-user
Loading

Prerequisites

Have Google Accessibility Scanner installed.

Steps to reproduce

  1. Open app and go to "http://testsafebrowsing.appspot.com/s/phishing.html"
  2. Scan the "Deceptive site issue" page.

Expected behavior

There are no suggestions to make any changes.

Actual behavior

"Deceptive site issue" Page - "Go back" button

  • backButton
    This item's height is 35dp. Consider making the height of this touch target 48dp or larger.

Device information

  • Android device: Samsung Galaxy S9 (Android 8)
  • Fenix version: Nightly 200407 (Build #20980610)

Screenshot
"Deceptive site issue" Page - "Go back" button
Screenshot_20200407-154236_Accessibility Scanner

┆Issue is synchronized with this Jira Task
@Diana-Rus Diana-Rus added 🐞 bug Crashes, Something isn't working, .. Feature:ErrorMessages S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist access Accessibility: Talkback, HW keyboard/mouse, braile display etc. labels Apr 7, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 7, 2020
@Diana-Rus Diana-Rus removed the needs:triage Issue needs triage label Apr 7, 2020
@Diana-Rus Diana-Rus changed the title [Bug][a11y] Error Page-Touch target-"Deceptive site issue" page height needs to be increased [Bug][a11y] Error Page-Touch target-"Deceptive site issue" page "Go back" button's height needs to be increased Apr 8, 2020
@asadotzler asadotzler added the P2 Upcoming release label May 7, 2020
@mcarare mcarare self-assigned this Jun 4, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#9771, mozilla-mobile#9768: Adjust touch target for…
996ae0e 
… buttons in error pages
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#9771, mozilla-mobile#9768: Adjust touch target for…
e71fb12 
… buttons in error pages
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#9771, mozilla-mobile#9768: Adjust touch target for…
c68df3e 
… buttons in error pages
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#9771, mozilla-mobile#9768: Adjust touch target for…
6e342ad 
… buttons in error pages
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#9771, mozilla-mobile#9768: Adjust touch target for…
7a2cc95 
… buttons in error pages
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#9771, mozilla-mobile#9768: Adjust touch target for…
03102ec 
… buttons in error pages
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#9771, mozilla-mobile#9768: Adjust touch target for…
e69d9d2 
… buttons in error pages
mcarare added a commit to mcarare/fenix that referenced this issue Jun 4, 2020
@mcarare
For mozilla-mobile#9771, mozilla-mobile#9768: Adjust touch target for…
56a3320 
… buttons in error pages
mcarare added a commit that referenced this issue Jun 4, 2020
@mcarare
For #9771, #9768: Adjust touch target for buttons in error pages
efae61d
@mcarare mcarare added the eng:qa:needed QA Needed label Jun 5, 2020
@sflorean
Copy link
Contributor

sflorean commented Jun 9, 2020

Verified as fixed on Nightly 6/9 with Google Pixel (Android 10).

@sflorean sflorean closed this as completed Jun 9, 2020
@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 9, 2020
@liuche liuche mentioned this issue Jun 10, 2020
Closed
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:ErrorMessages P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@asadotzler @mcarare @Diana-Rus @sflorean