-
Notifications
You must be signed in to change notification settings - Fork 1.3k
8081 l10n screenshots test update latest #10023
8081 l10n screenshots test update latest #10023
Conversation
// settingsTP() | ||
// Screengrab.screenshot("settings-enhanced-tp") | ||
// mDevice.pressBack() | ||
settingsTP() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment still needed above or is the solution found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, should remove those
mDevice.pressBack() | ||
// settingsToolbar() | ||
// Screengrab.screenshot("SettingsSubMenuDefaultBrowserRobot_settings-toolbar") | ||
// mDevice.pressBack() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these three temporarily commented out? Need a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old setting that I have not removed the comments for. I will delete them
reviewer comments
8416e59
to
e94e5f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #10023 +/- ##
=========================================
Coverage 19.16% 19.17%
Complexity 521 521
=========================================
Files 337 337
Lines 13762 13762
Branches 1846 1846
=========================================
+ Hits 2638 2639 +1
Misses 10885 10885
+ Partials 239 238 -1
Continue to review full report at Codecov.
|
These tests are not running as part as the regular UI tests but we need to keep them up to date for when a set of screenshots is required.
Some modifications were needed so that they work again as well as a new test added for showing one more screen.