Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

8081 l10n screenshots test update latest #10023

Conversation

isabelrios
Copy link
Contributor

These tests are not running as part as the regular UI tests but we need to keep them up to date for when a set of screenshots is required.

Some modifications were needed so that they work again as well as a new test added for showing one more screen.

@isabelrios isabelrios requested a review from AaronMT April 17, 2020 15:32
// settingsTP()
// Screengrab.screenshot("settings-enhanced-tp")
// mDevice.pressBack()
settingsTP()
Copy link
Contributor

@AaronMT AaronMT Apr 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment still needed above or is the solution found?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, should remove those

mDevice.pressBack()
// settingsToolbar()
// Screengrab.screenshot("SettingsSubMenuDefaultBrowserRobot_settings-toolbar")
// mDevice.pressBack()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these three temporarily commented out? Need a comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old setting that I have not removed the comments for. I will delete them

@isabelrios isabelrios force-pushed the 8081-l10n-screenshots-test-update-latest branch from 8416e59 to e94e5f1 Compare April 17, 2020 16:24
@codecov-io
Copy link

Codecov Report

Merging #10023 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10023   +/-   ##
=========================================
  Coverage     19.16%   19.17%           
  Complexity      521      521           
=========================================
  Files           337      337           
  Lines         13762    13762           
  Branches       1846     1846           
=========================================
+ Hits           2638     2639    +1     
  Misses        10885    10885           
+ Partials        239      238    -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/components/Search.kt 100.00% <0.00%> (+8.33%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7b875...e94e5f1. Read the comment docs.

@AaronMT AaronMT merged commit 587bdfb into mozilla-mobile:master Apr 20, 2020
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants