Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

fixed audioPlaybackSystemNotificationTest flaky test #10649

Merged
merged 1 commit into from
May 14, 2020

Conversation

sv-ohorvath
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath self-assigned this May 14, 2020
@sv-ohorvath sv-ohorvath added eng:automation Build automation, Continuous integration, .. eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer labels May 14, 2020
@sv-ohorvath sv-ohorvath changed the title disabled audioPlaybackSystemNotificationTest flaky test fixed audioPlaybackSystemNotificationTest flaky test May 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #10649 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10649   +/-   ##
=========================================
  Coverage     19.19%   19.19%           
  Complexity      599      599           
=========================================
  Files           360      360           
  Lines         14807    14807           
  Branches       2001     2001           
=========================================
  Hits           2842     2842           
  Misses        11705    11705           
  Partials        260      260           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a6cc4...24ca401. Read the comment docs.

Copy link
Contributor

@mcarare mcarare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sv-ohorvath sv-ohorvath merged commit 19dd057 into master May 14, 2020
@sv-ohorvath sv-ohorvath deleted the disableMediaTests branch May 14, 2020 15:17
@liuche liuche mentioned this pull request May 19, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, .. eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants