Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove GAID from installation ping, and rename the ping to first_session #11392

Closed
4 tasks
liuche opened this issue Jun 9, 2020 · 4 comments
Closed
4 tasks
Assignees

Comments

@liuche
Copy link
Contributor

liuche commented Jun 9, 2020

Description & Product Manager / Data Scientist User Story

from @magorlick:

  • We remove the device_id (GAID) as planned, from the installation ping (the activation ping should be unchanged)
  • We change the name of the event from 'installation' to 'first_session'.

The second change is needed for two reasons. The moment the event captures is actually NOT the installation event. Instead, it truly is the first time the app is opened. This removes ambiguity from the name. Folks do care about the difference in these two numbers. Secondly, we need to have an aggressive policy from deleting the data moving forward. By changing the event name we can simply reject all events with the name 'installation' and accept the first_session telemetry that does not have the device_id.

What questions will you answer with this data?

This is removing telemetry that we don't need anymore.

Acceptance Criteria

  • Remove GAID from installation ping
  • Rename installation ping to first_session and update telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 9, 2020
@liuche liuche removed the needs:triage Issue needs triage label Jun 9, 2020
@sblatz sblatz self-assigned this Jun 12, 2020
@sblatz
Copy link
Contributor

sblatz commented Jun 12, 2020

I don't see the GAID in master in the InstallationPing I will touch base with Marissa to see if we need to remove from a different build?

@sblatz
Copy link
Contributor

sblatz commented Jun 12, 2020

Touched base, we just need to push a new build to the Fenix Beta channel once the PMF experiment is over and we'll automatically drop the GAID since it's not in master. I will update the first_session thing though.

@sblatz
Copy link
Contributor

sblatz commented Jun 23, 2020

Chatting with marissa about this on slack because there's a bug in the glean documentation generation that stops us from having a ping with an underscore OR hyphen in it. (we should be allowed to us hyphens).

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 26, 2020

Hi, verified as fixed on both the latest Nightly Build 200626 from 6/26 and Beta 78.0.0-beta.1 from 6/26 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

✔️ First_session ping - Nightly installed through a marketing campaign

{
      "client_info": {
        "android_sdk_version": "29",
        "app_build": "21780613",
        "app_channel": "fenixNightly",
        "app_display_version": "Nightly 200626 06:01",
        "architecture": "arm64-v8a",
        "client_id": "41224a9d-29b3-482e-b49f-e3c4b904e2cb",
        "device_manufacturer": "Google",
        "device_model": "Pixel 3a",
        "first_run_date": "2020-06-26+03:00",
        "locale": "en-US",
        "os": "Android",
        "os_version": "10",
        "telemetry_sdk_build": "31.1.1"
      },
      "metrics": {
        "datetime": {
          "first_session.timestamp": "2020-06-26T11:19:20.946+03:00"
        },
        "string": {
          "first_session.adgroup": "twitter",
          "first_session.campaign": "social",
          "first_session.creative": "fr-gtm",
          "first_session.network": "Product Marketing"
        }
      },
      "ping_info": {
        "end_time": "2020-06-26T11:19+03:00",
        "seq": 0,
        "start_time": "2020-06-26T11:19+03:00"
      }
    }

✔️ First_session ping - Beta migration Organic install

{
      "client_info": {
        "android_sdk_version": "28",
        "app_build": "2015748425",
        "app_channel": "fennecBeta",
        "app_display_version": "78.0.0-beta.1",
        "architecture": "arm64-v8a",
        "client_id": "6bb938da-5437-4937-83fa-62abedcd93c1",
        "device_manufacturer": "HUAWEI",
        "device_model": "SNE-LX1",
        "first_run_date": "2020-06-26+03:00",
        "locale": "en-ES",
        "os": "Android",
        "os_version": "9",
        "telemetry_sdk_build": "31.1.1"
      },
      "metrics": {
        "datetime": {
          "first_session.timestamp": "2020-06-26T10:29:22.402+03:00"
        },
        "string": {
          "first_session.adgroup": "",
          "first_session.campaign": "",
          "first_session.creative": "",
          "first_session.network": "Organic"
        }
      },
      "ping_info": {
        "end_time": "2020-06-26T10:29+03:00",
        "seq": 0,
        "start_time": "2020-06-26T10:29+03:00"
      }
    }

Logcat OnePlus
Glean dashboard - OnePlus A3

Logcat Huawei
Glean dashboard - Huawei Mate 20 Lite

Logcat Pixel 3a
Glean dashboard - Google Pixel 3a

As @sblatz mentioned, the GAID (device_id) was never displayed in the installation ping. (correct me if I'm wrong ☺️ )

@AndiAJ AndiAJ closed this as completed Jun 26, 2020
@AndiAJ AndiAJ added the eng:qa:verified QA Verified label Jun 26, 2020
@liuche liuche mentioned this issue Jun 27, 2020
12 tasks
@data-sync-user data-sync-user changed the title Remove GAID from installation ping, and rename the ping to first_session FNX2-16492 ⁃ Remove GAID from installation ping, and rename the ping to first_session Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX2-16492 ⁃ Remove GAID from installation ping, and rename the ping to first_session FNX3-14603 ⁃ Remove GAID from installation ping, and rename the ping to first_session Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14603 ⁃ Remove GAID from installation ping, and rename the ping to first_session FNX-12321 ⁃ Remove GAID from installation ping, and rename the ping to first_session Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12321 ⁃ Remove GAID from installation ping, and rename the ping to first_session FNX2-16492 ⁃ Remove GAID from installation ping, and rename the ping to first_session Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16492 ⁃ Remove GAID from installation ping, and rename the ping to first_session Remove GAID from installation ping, and rename the ping to first_session May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants