Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Delete unnecessary to-dos #12603

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

eliserichards
Copy link
Contributor

For #12596

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@NotWoods NotWoods changed the title No issue: Delete unnecessary to-dos No issue: Delete unnecessary to-dos [ci skip] Jul 15, 2020
@eliserichards
Copy link
Contributor Author

Waiting on #10806

@hkaancaliskan
Copy link

Lol, why is this waiting. Just deleting TO-DO's.
@ekager i think we can land this without waiting CI?

@NotWoods
Copy link
Contributor

There was another PR to fix failing tests, which is why other PRs have been waiting

@eliserichards eliserichards changed the title No issue: Delete unnecessary to-dos [ci skip] No issue: Delete unnecessary to-dos Jul 16, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12603 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #12603   +/-   ##
=========================================
  Coverage     25.14%   25.14%           
- Complexity      844      845    +1     
=========================================
  Files           389      389           
  Lines         15666    15701   +35     
  Branches       2019     2022    +3     
=========================================
+ Hits           3939     3948    +9     
- Misses        11420    11445   +25     
- Partials        307      308    +1     
Impacted Files Coverage Δ Complexity Δ
app/src/main/java/org/mozilla/fenix/ext/String.kt 61.36% <ø> (ø) 0.00 <0.00> (ø)
...a/org/mozilla/gecko/search/SearchWidgetProvider.kt 24.32% <0.00%> (-9.01%) 1.00% <0.00%> (+1.00%) ⬇️
...nix/components/toolbar/BrowserToolbarController.kt 69.64% <0.00%> (+2.38%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b997fba...094a31e. Read the comment docs.

@eliserichards
Copy link
Contributor Author

@hakkikaancaliskan we do not land PRs without CI. All tests and checks must be run.

@eliserichards eliserichards merged commit 4fe1fb8 into mozilla-mobile:master Jul 16, 2020
@liuche liuche mentioned this pull request Jul 20, 2020
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants