-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closes #1195: Adds telemetry for quick action sheet #1362
Conversation
8c2b89e
to
3fbc07d
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 03/01/2020
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to send these events through the Glean SDK? You'll have to wire up the metrics.yaml / GleanMetricsProvider (example here: #1344)
Another nit: We should keep the Components as simple as possible and delegate the actual metrics collection to the component owner through the event bus.
3fbc07d
to
506968e
Compare
@boek Made the changes you requested 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there 😁 just one quick update and I think we'll be good to go! If you're interested about the structure of metrics.yaml
there is good documentation here on what everything means
506968e
to
651df50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes, inside metrics.yaml
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, through the telemetry toggle inside settings
- If the request is for permanent data collection, is there someone who will monitor the data over time?**
Expires in 3/1/2020
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **
Type 2 events are user interaction
- Is the data collection request for default-on or default-off?
Default on
-
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No, user interaction with UI -
Is the data collection covered by the existing Firefox privacy notice?
Type 2, interaction with the quick action sheet
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
yes, we will revisit renewing Fenix events next February before the expiration
- Does the data collection use a third-party collection tool?
no
Pull Request checklist
No tests as this is just a telemetry change