For #16941 - [Telemetry] Bookmark Counts

[gabrielluong]

Fixes #16941

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[codecov-io]

Codecov Report

Merging #16942 (2833a0a) into master (edca0e0) will decrease coverage by 0.01%.
The diff coverage is 24.24%.

@@             Coverage Diff              @@
##             master   #16942      +/-   ##
============================================
- Coverage     30.82%   30.81%   -0.02%     
  Complexity     1239     1239              
============================================
  Files           455      455              
  Lines         18577    18610      +33     
  Branches       2595     2605      +10     
============================================
+ Hits           5726     5734       +8     
- Misses        12392    12413      +21     
- Partials        459      463       +4     

Impacted Files	Coverage Δ	Complexity Δ
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt	6.76% <0.00%> (-0.43%)	14.00 <0.00> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt	12.95% <25.00%> (+0.18%)	5.00 <0.00> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt	70.97% <100.00%> (+0.37%)	35.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edca0e0...01ee600. Read the comment docs.

[gabrielluong]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1) What questions will you answer with this data?
How often do users interact with bookmarks?

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
This is important for the Nimbus Fenix Bookmarks A/B experiment to measure engagement with saving bookmarks.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
We already have existing event pings for the bookmark menu items. However, we do not currently report the bookmark counts between the desktop and mobile folders.

4) Can current instrumentation answer these questions?
No. See the above.

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description	Data Collection Category	Tracking Bug #
Bookmarks Count in the Desktop Folder	Category 2	https://github.com//issues/16941
Bookmarks Count in the Mobile Folder	Category 2	https://github.com//issues/16941

6) Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
This collection is documented in the metrics.md document document included in the project - https://github.com/mozilla-mobile/fenix/blob/master/docs/metrics.md

7) How long will this data be collected? Choose one of the following:
2021-08-01

8) What populations will you measure?
All release channels and locales.

9) If this data collection is default on, what is the opt-out mechanism for users?
Users can opt of of data collection by disabling Usage and technical data from Settings -> Data collection.

10) Please provide a general description of how you will analyze this data.
Glean / Amplitude

11) Where do you intend to share the results of your analysis?
Only on Glean, Amplitude and with mobile teams.

12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
No.

[eliserichards]

This looks good! Just one nit that @kglazko noted 😄

[eliserichards]

Awesome! This looks good to me 👍 🚀

[kglazko]

Thanks for clarifying, looks great to me!

[boek]

Data Review Form (to be filled by Data Stewards)

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, metrics.yaml and metrics.md

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, Fenix data collection settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   No, Fenix team will monitor

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Type 2

5. Is the data collection request for default-on or default-off?
   Default on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
   No

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes

8. Does there need to be a check-in in the future to determine whether to renew the data?
   Has expiry

9. Does the data collection use a third-party collection tool?
   No