For #22870: Renew/remove metrics set to expire in February #23453

eliserichards · 2022-01-27T21:57:21Z

For #22870

Product approval
Data review
Update data review in PR

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
click on the "Fenix - assemble" task, then click "Run Artifacts".
the APK links should be on the left side of the screen, named for each CPU architecture

eliserichards · 2022-01-28T22:14:11Z

Request for Data Collection Renewal

Never expire

Total: 9

———

toolbar_settings:
changed_position

Provide a link to the initial Data Collection Review Request for this collection.
- For #5694 & #6054: Allows users to change toolbar position #6608
When will this collection now expire?
- This probe will never expire.
Why was the initial period of collection insufficient?
- This is a foundational metric that will be used for future analysis.

———

install_source:

Provide a link to the initial Data Collection Review Request for this collection.
- For #22138 - Install source metrics probe #22224 (comment)
When will this collection now expire?
- This probe will never expire.
Why was the initial period of collection insufficient?
- This is a foundational metric that will be used for future analysis.

———

Preferences:
Accessibility_services

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add toggle states to metrics ping #11211
When will this collection now expire?
- This probe will never expire.
Why was the initial period of collection insufficient?
- This is a foundational metric that will be used for future analysis.

———

Preferences:
Search_suggestions_enabled

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add toggle states to metrics ping #11211
When will this collection now expire?
- This probe will never expire.
Why was the initial period of collection insufficient?
- This is a foundational metric that will be used for future analysis for search.

———

Preferences:
Open_links_in_app_enabled
User_theme (light/dark/system/battery)

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add missing telemetry #11446
When will this collection now expire?
- These probes will never expire.
Why was the initial period of collection insufficient?
- These are foundational metrics that are used to understand how we perform in/interact with the Android ecosystem.

———

Preferences:
Telemetry_enabled
Toolbar_position_setting
Search_shortcuts_enabled

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add toggle states to metrics ping #11211
When will this collection now expire?
- These probes will never expire.
Why was the initial period of collection insufficient?
- These are foundational metrics that will be used for future analysis.

==================
 ## Renew for 1 year
Total: 83

———

search_shortcuts:
selected:

Provide a link to the initial Data Collection Review Request for this collection.
- Closes #1194: Adds search shortcut telemetry #1202 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- The team will be touching search-related features and this will be necessary foundational data for any changes.

———

login_dialog:
displayed:
Cancelled:
saved:
Never_save:

Provide a link to the initial Data Collection Review Request for this collection.
- For #9730: Add Login Dialog Prompt telemetry #13050
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- This is a foundational metric that will be used for future analysis.

———

has_desktop_bookmarks:

Provide a link to the initial Data Collection Review Request for this collection.
- For #16941 - [Telemetry] Bookmark Counts #16942
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- This is a foundational metric that will be used for future analysis.

———

recently_used_pwa_count:
has_recent_pwas

Provide a link to the initial Data Collection Review Request for this collection.
- Closes #11909: Metrics for recording number of recently used PWAs #11982 (review)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
-3) Since PWA’s are mobile-platform-only (don’t exist on desktop), it’s important to understand how they are being used so that we can leverage this for product/marketing in the future.

———

mozilla_products
default_moz_browser

Provide a link to the initial Data Collection Review Request for this collection.
- [Waiting on Data Review] For #1192: Adds telemetry for Mozilla products #1953
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- This is a foundational metric that will be used for future analysis.

———

Adjust_campaign

Provide a link to the initial Data Collection Review Request for this collection.
- For #1298: Adds adjustCampaignId to core ping #5579
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Still using these for active success on major releases.

———

adjust_ad_group:
adjust_creative:
Adjust_network:

Provide a link to the initial Data Collection Review Request for this collection.
- For #9136: Send all adjust properties to glean #9253
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Still using these for active success on major releases.

———

toolbar_position:

Provide a link to the initial Data Collection Review Request for this collection.
- For #5694 & #6054: Allows users to change toolbar position #6608
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- This is a foundational metric that will be used for future analysis. We might roll all of the toolbar position probes into one (I believe there are at least three at the moment) but that will be future work.

———

Close_tab_setting
Tab_view_setting

Why was the initial period of collection insufficient?
Provide a link to the initial Data Collection Review Request for this collection.
- For #15347 - Adds telemetry for tab settings #15811 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Helps us understand key user behavior

———

search_widget_installed:

Provide a link to the initial Data Collection Review Request for this collection.
- For #9488: Add Search widget CFR & telemetry #10958
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational how users use product, might want to leverage this to increase search engagement in the future.

———

has_open_tabs:

Provide a link to the initial Data Collection Review Request for this collection.
- For #11479: Record open tabs count in metrics ping #12024
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
foundational

———

inactive_tabs_count:

Provide a link to the initial Data Collection Review Request for this collection.
- For #22155 - Inactive tabs count telemetry #22163 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- This is important to continue monitoring the MR2 work from late 2022.

———

Preferences:
Toolbar_position_setting
Search_shortcuts_enabled

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add toggle states to metrics ping #11211
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- This is foundational.

———

Preferences:
Enhanced_tracking_protection
Bookmarks_suggestion
Browsing_history_suggestion
Voice_search_enabled

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add toggle states to metrics ping #11211
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- These will be important for upcoming changes in the next year.

———

Preferences:
Clipboard_suggestions_enabled

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add toggle states to metrics ping #11211
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- This will be important for updating to Android 12.

———

Preferences:
Signed_in_sync
Sync_items

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add toggle states to metrics ping #11211
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- These are important for monitoring sync performance.

———

Preferences:
Inactive_tabs_survey_opened
turn_off_inactive_tabs_survey

Provide a link to the initial Data Collection Review Request for this collection.
- For #21732 - Adds inactive tabs survey on disable #21862 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- These are still in use for the survey.

———

Preferences
Search_url

Provide a link to the initial Data Collection Review Request for this collection.
- For #800 - Adds metrics for the default search engine #1606
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational for our search revenue.

———

Sync_auth:
Closed
recovered
scan_pairing
Opened:

Provide a link to the initial Data Collection Review Request for this collection.
- For #1190: Adds telemetry for FxA login #2745 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Used by sync team for monitoring

———

sync_account
Opened:
sync_now

Provide a link to the initial Data Collection Review Request for this collection.
- For #1190: Adds telemetry for FxA login #2745 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Used by sync team for monitoring

———

Sync_auth:
use_email_problem:
Use_email

Provide a link to the initial Data Collection Review Request for this collection.
- Add 'useEmail' metrics event #9835 (review)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Used by sync team for monitoring

———

Sync_auth:
Other_external:
Recovered
paired

Provide a link to the initial Data Collection Review Request for this collection.
- FxA WebChannels integration #4931 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Used by sync team for monitoring

———

Sync_account:
sign_in_to_send_tab
send_tab:

Provide a link to the initial Data Collection Review Request for this collection.
- For #4908: Adds metrics for send tab telemetry #5106
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Used by sync team for monitoring

———

history:
Opened:
removed
removed_all
shared

Provide a link to the initial Data Collection Review Request for this collection.
- For #2362: Adds telemetry for history #3940
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- These are foundational.

———

search_widget:
New_tab_button:
voice_button

Provide a link to the initial Data Collection Review Request for this collection.
- For #4457: Adds telemetry for search widget actions #4714
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Might want to leverage in the future, plus they are foundational with regards to search.

———

tracking_protection:
Exception_added (user added exception from panel)
Panel_settings (opened settings from panel)
Etp_shield (tapped shield icon)
Etp_tracker_list (clicked into a list of categorized trackers in the panel)
Etp_settings (opened from settings menu)
etp_setting_changed

Provide a link to the initial Data Collection Review Request for this collection.
- For #5312 - Add Telemetry for Tracking Protection #5414 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational; MR2 made changes to this and more changes are planned.

———

tab:
media_play:
Media_pause:

Provide a link to the initial Data Collection Review Request for this collection.
- For #5197: Adds telemetry for media controls #5266
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Relevant to determine future work

———

media_notification:
play:
Pause:

Provide a link to the initial Data Collection Review Request for this collection.
- For #5197: Adds telemetry for media notification #5520
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- These are foundational metrics.

———

Media_state:
Play
Pause
Stop

Provide a link to the initial Data Collection Review Request for this collection.
- For #5705 - Adds telemetry for media state #6463
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- These are foundational, but they might also be tracked by gecko.

———

Media_state:
Picture_in_picture
fullscreen

Provide a link to the initial Data Collection Review Request for this collection.
- For #15368 - Adds telemetry for fullscreen, pip #16833
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Understanding use and bugs. Outside of GV, so this would be the only way to see it

———

Logins:
Open_individual_login:
copy_login
view_password_login

Provide a link to the initial Data Collection Review Request for this collection.
- For #5586 - Adds Logins Telemetry #6352
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational, and will provide insight for whether we might want to invest more time in this.

———

Logins
Save_logins_setting_changed

Provide a link to the initial Data Collection Review Request for this collection.
- For #5586 - Add telemetry for save logins setting #7767
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational, and will provide insight for whether we might want to invest more time in this.

———

Logins
Open_login_editor:
delete_saved_login
save_edited_login

Provide a link to the initial Data Collection Review Request for this collection.
- For #10173: login duplicates and save #11208
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational, and will provide insight for whether we might want to invest more time in this.

———

voice_search:
tapped:

Provide a link to the initial Data Collection Review Request for this collection.
- For #10465: Add telemetry for voice search #10785
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- We want to continue monitoring this to evaluate it’s effectiveness.

———

open_baidu_search_attribution:

Provide a link to the initial Data Collection Review Request for this collection.
- Closes #19490 : Add event ping telemetry for the Baidu top site click #20705
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational for the China team.

———

Google_top_site_removed
Baidu_top_site_removed

Provide a link to the initial Data Collection Review Request for this collection.
- For #21841 - New telemetry for Google and Baidu top sites removal #21845 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- These are foundational.

———

pocket_top_site_removed:

Provide a link to the initial Data Collection Review Request for this collection.
- For #8126 - Adds default top sites #8098
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational; maybe revisit this now that pocket is on home

———

autoplay:
Visited_setting:
setting_changed

Provide a link to the initial Data Collection Review Request for this collection.
- For #11579 - Adds telemetry for autoplay settings in Site Permissions #13041 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- We want to continue collecting data on this for future work.

———

synced_tabs:
synced_tabs_suggestion_clicked:

Provide a link to the initial Data Collection Review Request for this collection.
- Closes #18163: Use SyncedTabsFacts for Synced Tab Telemetry #18172
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- There will be upcoming work on this and we need to collect baseline data.

———

Recent_bookmarks
Bookmark_clicked:
show_all_bookmarks:

Provide a link to the initial Data Collection Review Request for this collection.
- For #19931: Add telemetry probes for recent bookmarks on home screen #20316 (comment)
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- MR2 work that needs continued monitoring

———

Remote_debugging_enabled

Provide a link to the initial Data Collection Review Request for this collection.
- For #11118: Add toggle states to metrics ping #11211
When will this collection now expire?
- This probe will now expire in February 2023 (one year).
Why was the initial period of collection insufficient?
- Foundational for engineering.

rocketsroger · 2022-01-28T22:17:39Z

Request for Data Collection Renewal

Never expire

Total: 9

———

toolbar_settings: changed_position

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [ For #5694 & #6054: Allows users to change toolbar position #6608](https://github.com/mozilla-mobile/fenix/pull/6608)

2. When will this collection now expire?
   
   * This probe will never expire.

3. Why was the initial period of collection insufficient?
   
   * This is a foundational metric that will be used for future analysis.

———

install_source:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #22138 - Install source metrics probe #22224 (comment)](https://github.com/mozilla-mobile/fenix/pull/22224#issuecomment-956749994)

2. When will this collection now expire?
   
   * This probe will never expire.

3. Why was the initial period of collection insufficient?
   
   * This is a foundational metric that will be used for future analysis.

———

Preferences: Accessibility_services

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

2. When will this collection now expire?
   
   * This probe will never expire.

3. Why was the initial period of collection insufficient?
   
   * This is a foundational metric that will be used for future analysis.

———

Preferences: Search_suggestions_enabled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

2. When will this collection now expire?
   
   * This probe will never expire.

3. Why was the initial period of collection insufficient?
   
   * This is a foundational metric that will be used for future analysis for search.

———

Preferences: Open_links_in_app_enabled User_theme (light/dark/system/battery)

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add missing telemetry #11446](https://github.com/mozilla-mobile/fenix/pull/11446)

2. When will this collection now expire?
   
   * These probes will never expire.

3. Why was the initial period of collection insufficient?
   
   * These are foundational metrics that are used to understand how we perform in/interact with the Android ecosystem.

———

Preferences: Telemetry_enabled Toolbar_position_setting Search_shortcuts_enabled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

2. When will this collection now expire?
   
   * These probes will never expire.

3. Why was the initial period of collection insufficient?
   
   * These are foundational metrics that will be used for future analysis.

==================  ## Renew for 1 year Total: 83

———

search_shortcuts: selected:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Closes #1194: Adds search shortcut telemetry #1202 (comment)](https://github.com/mozilla-mobile/fenix/pull/1202#issuecomment-476870449)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * The team will be touching search-related features and this will be necessary foundational data for any changes.

———

login_dialog: displayed: Cancelled: saved: Never_save:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #9730: Add Login Dialog Prompt telemetry #13050](https://github.com/mozilla-mobile/fenix/pull/13050)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * This is a foundational metric that will be used for future analysis.

———

has_desktop_bookmarks:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #16941 - [Telemetry] Bookmark Counts #16942](https://github.com/mozilla-mobile/fenix/pull/16942)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * This is a foundational metric that will be used for future analysis.

———

recently_used_pwa_count: has_recent_pwas

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Closes #11909: Metrics for recording number of recently used PWAs #11982 (review)](https://github.com/mozilla-mobile/fenix/pull/11982#pullrequestreview-437963817)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   -3) Since PWA’s are mobile-platform-only (don’t exist on desktop), it’s important to understand how they are being used so that we can leverage this for product/marketing in the future.

———

mozilla_products default_moz_browser

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [[Waiting on Data Review] For  #1192: Adds telemetry for Mozilla products #1953](https://github.com/mozilla-mobile/fenix/pull/1953)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * This is a foundational metric that will be used for future analysis.

———

Adjust_campaign

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #1298: Adds adjustCampaignId to core ping #5579](https://github.com/mozilla-mobile/fenix/pull/5579)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Still using these for active success on major releases.

———

adjust_ad_group: adjust_creative: Adjust_network:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #9136: Send all adjust properties to glean #9253](https://github.com/mozilla-mobile/fenix/pull/9253)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Still using these for active success on major releases.

———

toolbar_position:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [ For #5694 & #6054: Allows users to change toolbar position #6608](https://github.com/mozilla-mobile/fenix/pull/6608)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * This is a foundational metric that will be used for future analysis. We might roll all of the toolbar position probes into one (I believe there are at least three at the moment) but that will be future work.

———

Close_tab_setting Tab_view_setting

3. Why was the initial period of collection insufficient?

4. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #15347 - Adds telemetry for tab settings #15811 (comment)](https://github.com/mozilla-mobile/fenix/pull/15811#issuecomment-706402952)

5. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

6. Why was the initial period of collection insufficient?
   
   * Helps us understand key user behavior

———

search_widget_installed:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [ For #9488: Add Search widget CFR & telemetry #10958](https://github.com/mozilla-mobile/fenix/pull/10958)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Foundational how users use product, might want to leverage this to increase search engagement in the future.

———

has_open_tabs:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11479: Record open tabs count in metrics ping #12024](https://github.com/mozilla-mobile/fenix/pull/12024)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   foundational

———

inactive_tabs_count:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #22155 - Inactive tabs count telemetry #22163 (comment)](https://github.com/mozilla-mobile/fenix/pull/22163#issuecomment-957636802)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * This is important to continue monitoring the MR2 work from late 2022.

———

Preferences: Telemetry_enabled Toolbar_position_setting Search_shortcuts_enabled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. ## Why was the initial period of collection insufficient?

———

Preferences: Enhanced_tracking_protection Bookmarks_suggestion Browsing_history_suggestion Voice_search_enabled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * These will be important for upcoming changes in the next year.

——— Preferences: Clipboard_suggestions_enabled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * This will be important for updating to Android 12.
     ———

Preferences: Signed_in_sync Sync_items

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * These are important for monitoring sync performance.

———

Preferences. Inactive_tabs_survey_opened: - turn_off_inactive_tabs_survey

* [For #21732 - Adds inactive tabs survey on disable #21862 (comment)](https://github.com/mozilla-mobile/fenix/pull/21862#issuecomment-949598042)


1. ## Provide a link to the initial Data Collection Review Request for this collection.

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?

———

Preferences. Search_url - foundational, check with search

* [For #800 - Adds metrics for the default search engine #1606](https://github.com/mozilla-mobile/fenix/pull/1606)


1. ## Provide a link to the initial Data Collection Review Request for this collection.

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?

———

Sync_auth: Closed recovered scan_pairing Opened:

 - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532

1. ## Provide a link to the initial Data Collection Review Request for this collection.

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Used by sync team for monitoring

———

sync_account: Opened: sync_now

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #1190: Adds telemetry for FxA login #2745 (comment)](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Used by sync team for monitoring

———

Sync_auth: use_email_problem: Use_email

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add 'useEmail' metrics event #9835 (review)](https://github.com/mozilla-mobile/fenix/pull/9835#pullrequestreview-398641844)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Used by sync team for monitoring

———

Sync_auth: Other_external: Recovered paired

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [FxA WebChannels integration  #4931 (comment)](https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Used by sync team for monitoring

———

Sync_account: sign_in_to_send_tab send_tab:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #4908: Adds metrics for send tab telemetry #5106](https://github.com/mozilla-mobile/fenix/pull/5106)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Used by sync team for monitoring

———

history: Opened: removed removed_all shared

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #2362: Adds telemetry for history #3940](https://github.com/mozilla-mobile/fenix/pull/3940)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * These are foundational.

———

search_widget: New_tab_button: voice_button

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #4457: Adds telemetry for search widget actions #4714](https://github.com/mozilla-mobile/fenix/pull/4714)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   - Might want to leverage in the future, plus they are foundational with regards to search.

———

tracking_protection: Exception_added: (user added exception from panel) Panel_settings (opened settings from panel) Etp_shield (tapped shield icon) Etp_tracker_list (clicked into a list of categorized trackers in the panel) Etp_settings (opened from settings menu) etp_setting_changed

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #5312 - Add Telemetry for Tracking Protection #5414 (comment)](https://github.com/mozilla-mobile/fenix/pull/5414#issuecomment-532847188)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   - Foundational; MR2 made changes to this and more changes are planned.

tab: media_play: Media_pause:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #5197: Adds telemetry for media controls #5266](https://github.com/mozilla-mobile/fenix/pull/5266)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Relevant to determine future work

media_notification: play: Pause:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #5197: Adds telemetry for media notification #5520](https://github.com/mozilla-mobile/fenix/pull/5520)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * These are foundational metrics.

Media_state: Play Pause Stop

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #5705 - Adds telemetry for media state #6463](https://github.com/mozilla-mobile/fenix/pull/6463)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * These are foundational, but they might also be tracked by gecko.

Media_state: Picture_in_picture fullscreen

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #15368  - Adds telemetry for fullscreen, pip #16833](https://github.com/mozilla-mobile/fenix/pull/16833)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Understanding use and bugs. Outside of GV, so this would be the only way to see it

Logins: Open_individual_login: copy_login view_password_login

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #5586 - Adds Logins Telemetry #6352](https://github.com/mozilla-mobile/fenix/pull/6352)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Foundational, and will provide insight for whether we might want to invest more time in this.

Logins Save_logins_setting_changed: (incl extras with setting name)

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #5586 - Add telemetry for save logins setting #7767](https://github.com/mozilla-mobile/fenix/pull/7767)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Foundational, and will provide insight for whether we might want to invest more time in this.

Logins Open_login_editor: delete_saved_login save_edited_login

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #10173: login duplicates and save #11208](https://github.com/mozilla-mobile/fenix/pull/11208)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Foundational, and will provide insight for whether we might want to invest more time in this.

voice_search: tapped:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [ For #10465: Add telemetry for voice search  #10785](https://github.com/mozilla-mobile/fenix/pull/10785)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * We want to continue monitoring this to evaluate it’s effectiveness.

open_baidu_search_attribution:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Closes #19490 : Add event ping telemetry for the Baidu top site click #20705](https://github.com/mozilla-mobile/fenix/pull/20705)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Foundational for the China team.

Google_top_site_removed: Baidu_top_site_removed

   - https://github.com/mozilla-mobile/fenix/pull/21845#issuecomment-944608568

3. Why was the initial period of collection insufficient?
   
   * These are foundational.

pocket_top_site_removed:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #8126 - Adds default top sites  #8098](https://github.com/mozilla-mobile/fenix/pull/8098)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Foundational; maybe revisit this now that pocket is on home

autoplay: Visited_setting: setting_changed

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11579 - Adds telemetry for autoplay settings in Site Permissions #13041 (comment)](https://github.com/mozilla-mobile/fenix/pull/13041#issuecomment-665777411)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * We want to continue collecting data on this for future work.

synced_tabs: synced_tabs_suggestion_clicked:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Closes #18163: Use SyncedTabsFacts for Synced Tab Telemetry #18172](https://github.com/mozilla-mobile/fenix/pull/18172)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * There will be upcoming work on this and we need to collect baseline data.

Recent_bookmarks Bookmark_clicked: show_all_bookmarks:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #19931: Add telemetry probes for recent bookmarks on home screen #20316 (comment)](https://github.com/mozilla-mobile/fenix/pull/20316#issuecomment-888291843)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * MR2 work that needs continued monitoring

Remote_debugging_enabled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

2. When will this collection now expire?
   
   * This probe will now expire in February 2023 (one year).

3. Why was the initial period of collection insufficient?
   
   * Foundational for engineering.

Data Collection Renewal Review

Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

rocketsroger

Looks good to me! Update the data review URL and 🚢. Thanks for doing this.

eliserichards · 2022-01-31T19:42:33Z

@Mergifyio backport releases_v97.0.0

* For #22870: Renew/remove metrics set to expire in February * Add data review and add notification owner for never expire metrics (cherry picked from commit 6798f65) # Conflicts: # app/metrics.yaml

mergify · 2022-01-31T19:42:56Z

backport releases_v97.0.0

✅ Backports have been created

#23495 For #22870: Renew/remove metrics set to expire in February (backport #23453) has been created for branch releases_v97.0.0

…ary (mozilla-mobile#23453) * For mozilla-mobile#22870: Renew/remove metrics set to expire in February * Add data review and add notification owner for never expire metrics

eliserichards · 2022-01-31T20:17:01Z

Uplift PR: #23496

* For #22870: Renew/remove metrics set to expire in February (#23453) * For #22870: Renew/remove metrics set to expire in February * Add data review and add notification owner for never expire metrics * Close #22956: Define "tags" for metrics in the app repository Co-authored-by: William Lachance <wlach@protonmail.com> Define "tags" for metrics in the app repository Using the new "tags" feature in Glean, we can remove most of the manual process/pain of defining tags in a seperate Glean annotations repository (see: https://github.com/mozilla-mobile/fenix/wiki/Add-a-Glean-Annotation-for-an-event) and just put them beside the metrics themselves. This should make it much easier to keep this metadata up to date, since it can be added in the same pull request as the instrumentation itself. To keep the list of tags up to date with the Fenix issue labels, a new script `update-glean-tags.py` has been added to the repository. It should not need to be run often. This pull request uses a scraped version of the defined tags in the Glean annotations repository. After it lands, we can remove those and just use the tagging information here as the main source of information. Co-authored-by: Roger Yang <royang@mozilla.com>

rocketsroger · 2022-01-31T22:39:59Z

@Mergifyio backport releases_v96.0.0

* For #22870: Renew/remove metrics set to expire in February * Add data review and add notification owner for never expire metrics (cherry picked from commit 6798f65) # Conflicts: # app/metrics.yaml

mergify · 2022-01-31T22:40:44Z

backport releases_v96.0.0

✅ Backports have been created

#23507 For #22870: Renew/remove metrics set to expire in February (backport #23453) has been created for branch releases_v96.0.0

* For #22870: Renew/remove metrics set to expire in February (#23453) * For #22870: Renew/remove metrics set to expire in February * Add data review and add notification owner for never expire metrics * Close #22956: Define "tags" for metrics in the app repository Co-authored-by: William Lachance <wlach@protonmail.com> Define "tags" for metrics in the app repository Using the new "tags" feature in Glean, we can remove most of the manual process/pain of defining tags in a seperate Glean annotations repository (see: https://github.com/mozilla-mobile/fenix/wiki/Add-a-Glean-Annotation-for-an-event) and just put them beside the metrics themselves. This should make it much easier to keep this metadata up to date, since it can be added in the same pull request as the instrumentation itself. To keep the list of tags up to date with the Fenix issue labels, a new script `update-glean-tags.py` has been added to the repository. It should not need to be run often. This pull request uses a scraped version of the defined tags in the Glean annotations repository. After it lands, we can remove those and just use the tagging information here as the main source of information. Co-authored-by: Roger Yang <royang@mozilla.com> (cherry picked from commit 08790a0)

…23453)

…23453) (#23510) * For #22870: Renew/remove metrics set to expire in February (backport #23453) * Issue ##22870: Temporarily ignoring tests for StorageStatsMetrics * No issue: Update PWA package name in mainMenuInstallPWATest (#23335) Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com> Co-authored-by: Aaron Train <aaron.train@gmail.com>

…ary (mozilla-mobile#23453) * For mozilla-mobile#22870: Renew/remove metrics set to expire in February * Add data review and add notification owner for never expire metrics

eliserichards force-pushed the 22870-renew-metrics-feb branch 2 times, most recently from fe0da9e to cb6240e Compare January 28, 2022 18:17

rocketsroger approved these changes Jan 28, 2022

View reviewed changes

eliserichards marked this pull request as ready for review January 28, 2022 22:27

eliserichards requested review from a team as code owners January 28, 2022 22:27

eliserichards added 2 commits January 28, 2022 14:49

For mozilla-mobile#22870: Renew/remove metrics set to expire in February

b085976

Add data review and add notification owner for never expire metrics

51fb215

eliserichards force-pushed the 22870-renew-metrics-feb branch from dbc4ee1 to 51fb215 Compare January 28, 2022 22:49

eliserichards added the pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] label Jan 28, 2022

mergify bot merged commit 6798f65 into mozilla-mobile:main Jan 28, 2022

eliserichards linked an issue Jan 28, 2022 that may be closed by this pull request

Renew telemetry for February #22870

Closed

2 tasks

mergify bot mentioned this pull request Jan 31, 2022

For #22870: Renew/remove metrics set to expire in February (backport #23453) #23495

Closed

mergify bot mentioned this pull request Jan 31, 2022

For #22870: Renew/remove metrics set to expire in February (backport #23453) #23507

Closed

rocketsroger added a commit that referenced this pull request Jan 31, 2022

For #22870: Renew/remove metrics set to expire in February (backport #…

3d2d468

…23453)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For #22870: Renew/remove metrics set to expire in February #23453

For #22870: Renew/remove metrics set to expire in February #23453

eliserichards commented Jan 27, 2022 •

edited

Loading

eliserichards commented Jan 28, 2022 •

edited

Loading

rocketsroger commented Jan 28, 2022

Request for Data Collection Renewal

Never expire

rocketsroger left a comment

eliserichards commented Jan 31, 2022

mergify bot commented Jan 31, 2022

eliserichards commented Jan 31, 2022

rocketsroger commented Jan 31, 2022

mergify bot commented Jan 31, 2022

For #22870: Renew/remove metrics set to expire in February #23453

For #22870: Renew/remove metrics set to expire in February #23453

Conversation

eliserichards commented Jan 27, 2022 • edited Loading

Pull Request checklist

To download an APK when reviewing a PR:

eliserichards commented Jan 28, 2022 • edited Loading

Request for Data Collection Renewal

Never expire

rocketsroger commented Jan 28, 2022

Request for Data Collection Renewal

Never expire

Data Collection Renewal Review

Result

rocketsroger left a comment

Choose a reason for hiding this comment

eliserichards commented Jan 31, 2022

mergify bot commented Jan 31, 2022

✅ Backports have been created

eliserichards commented Jan 31, 2022

rocketsroger commented Jan 31, 2022

mergify bot commented Jan 31, 2022

✅ Backports have been created

eliserichards commented Jan 27, 2022 •

edited

Loading

eliserichards commented Jan 28, 2022 •

edited

Loading