Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Run UI test nightly #17017

Closed

Conversation

isabelrios
Copy link
Contributor

This is based on PR that has not landed yet, all those changes are needed and a few more... Just trying to have something similar to tests running on Beta but for Nightly while the work with that PR is finished

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@isabelrios
Copy link
Contributor Author

isabelrios commented Dec 16, 2020

We will need PR #16981 and #16786 before landing this, but would like to know your feedback in the meantime if that's possible @JohanLorenzo, only to the Nightly implementation part, the other should be familiar from the previous PR. thank you in advance!!!

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 2111adb looks great to me! I haven't looked to closely at the former ones because, they're from #16786, if I remember correctly.

@isabelrios
Copy link
Contributor Author

Commit 2111adb looks great to me! I haven't looked to closely at the former ones because, they're from #16786, if I remember correctly.

Yes, that's right! thanks for taking a look at it! 🙏

@isabelrios isabelrios closed this Dec 17, 2020
@isabelrios isabelrios reopened this Dec 17, 2020
@codecov-io
Copy link

codecov-io commented Dec 17, 2020

Codecov Report

Merging #17017 (2111adb) into master (9d5ec47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17017   +/-   ##
=========================================
  Coverage     30.89%   30.89%           
  Complexity     1240     1240           
=========================================
  Files           453      453           
  Lines         18519    18519           
  Branches       2583     2583           
=========================================
  Hits           5722     5722           
  Misses        12338    12338           
  Partials        459      459           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5ec47...2111adb. Read the comment docs.

@isabelrios
Copy link
Contributor Author

Closing this PR. A new one will be open to address the new changes needed for UI tests on Nightly builds

@isabelrios isabelrios closed this Jan 18, 2021
@isabelrios isabelrios mentioned this pull request Jan 18, 2021
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants