-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closes #18068: Use AwesomeBarFacts for AwesomeBar Telemetry #18090
Conversation
cc129c9
to
fde55f8
Compare
Request for data collection review
|
fde55f8
to
db79ea3
Compare
This pull request has conflicts when rebasing. Could you fix it @rocketsroger? 🙏 |
Data Review
Yes, via the metrics.md and other Glean tools.
Yes
Not applicable, the collection is set to end 2021-08-01.
Category 2, User Interaction
Default on
No
Yes
No, unless the owner decides to extend beyond 2021-08-01
No Result:data-review+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
@@ -85,4 +86,31 @@ class GleanMetricsServiceTest { | |||
assertEquals(1, events[0].extra!!.size) | |||
assertEquals("APP_ICON", events[0].extra!!["source"]) | |||
} | |||
|
|||
@Test | |||
fun `awesomebar events is correctly recorded`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: awesomebar events are correctly recorded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. I'll fix that when I resolve the conflicts. thanks for catching it.
Fixes #18068
Pull Request checklist
To download an APK when reviewing a PR: