Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Use AwesomeBarFacts for AwesomeBar Telemetry #18068

Closed
rocketsroger opened this issue Feb 18, 2021 · 8 comments · Fixed by #18090
Closed

Use AwesomeBarFacts for AwesomeBar Telemetry #18068

rocketsroger opened this issue Feb 18, 2021 · 8 comments · Fixed by #18090
Assignees
Milestone

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Feb 18, 2021

Collect Awesome Bar facts to be included in the Glean report.

┆Issue is synchronized with this Jira Task

@rocketsroger rocketsroger self-assigned this Feb 18, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 18, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Feb 19, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Feb 19, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Feb 19, 2021
@rocketsroger
Copy link
Contributor Author

Related #14866

@amedyne amedyne removed the needs:triage Issue needs triage label Feb 22, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Feb 22, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Mar 8, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Mar 8, 2021
@gabrielluong gabrielluong added this to the 88 milestone Mar 9, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Mar 9, 2021
@gabrielluong gabrielluong reopened this Mar 9, 2021
@lobontiumira
Copy link

Hi all!
I've verified on the 3/15 Nightly build with Google Pixel (Android 10), and here are my findings:

  • ping: e022beea-dba6-4d52-b870-1e505ad01ba8
  • bookmark_suggestion_clicked event was generated:
{
         "category": "awesomebar",
         "name": "bookmark_suggestion_clicked",
         "timestamp": 13776
       }
  • opened_tab_suggestion_clicked event was generated:
 {
          "category": "awesomebar",
          "name": "opened_tab_suggestion_clicked",
          "timestamp": 28030
        }
  • and history_suggestion_clicked was generated:
{
          "category": "awesomebar",
          "name": "history_suggestion_clicked",
          "timestamp": 18918
        }
  • search_action_clicked was generated when tapping on the mirrored searched term:
 {
          "category": "awesomebar",
          "name": "search_action_clicked",
          "timestamp": 3170
        }

I was not able to generate the following events:

  • clipboard_suggestion_clicked,
  • search_suggestion_clicked.

However, @Mugurell has more details about why these events are not generated. Thank you so much!

logcat.txt
Glean dashboard

@lobontiumira lobontiumira removed the eng:qa:needed QA Needed label Mar 15, 2021
@Mugurell
Copy link
Contributor

I looked with Mira over those two facts, why they are not logged and found:

@rocketsroger
Copy link
Contributor Author

@Mugurell Thanks for the investigation. I'll look into this.

@rocketsroger
Copy link
Contributor Author

@Mugurell Thanks for spending time on this. I've confirmed both your observation is correct. I'll add changes so the missing events are tracked correctly.

rocketsroger added a commit to rocketsroger/fenix that referenced this issue Apr 6, 2021
@rocketsroger rocketsroger reopened this Apr 7, 2021
@rocketsroger
Copy link
Contributor Author

Waiting for mozilla-mobile/android-components#10031 to merge.

@rocketsroger rocketsroger added the eng:qa:needed QA Needed label Apr 14, 2021
@rocketsroger
Copy link
Contributor Author

Nightly have the latest fix. Please verify, Thanks!

@abodea
Copy link
Member

abodea commented Apr 19, 2021

Hello verified as fixed on the latest Nightly 4/19 with Google Pixel 4 XL (11).

{
         "category": "awesomebar",
         "name": "bookmark_suggestion_clicked",
       }
  • opened_tab_suggestion_clicked event was generated:
 {
          "category": "awesomebar",
          "name": "opened_tab_suggestion_clicked",
        }
  • and history_suggestion_clicked was generated:
{
          "category": "awesomebar",
          "name": "history_suggestion_clicked",
        }
  • search_action_clicked was generated when tapping on the mirrored searched term:
 {
          "category": "awesomebar",
          "name": "search_action_clicked",
        }
  • clipboard_suggestion_clicked was generated when tapping on a copied suggestion:
 {
          "category": "awesomebar",
          "name": "clipboard_suggestion_clicked",
        }

*search_suggestion_clicked was generated when tapping on a search suggestion:

{
          "category": "awesomebar",
          "name": "search_suggestion_clicked",
        }

logcat1.txt
Glean Dashboard

@abodea abodea closed this as completed Apr 19, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 19, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants