Taskgraph changes to allow running UI tests on nightly builds #18191
Conversation
|
@escapewindow asking for review, as per comments in PR #17948. I'm creating this one with the changes mentioned there. Looks like things are working here for debug and nightly(added the try_task_config.json to see it running). I'm still afraid like in the past PRs, things may be messed up when landing in master but I can't think of any other way to try these changes... |
isabelrios
force-pushed
the
taskgraph-changes-to-run-ui-tests-on-nightly-builds
branch
from
d887d34
to
f0bb788
Compare
|
@pocmo, @escapewindow sorry for pinging you again for review, just in case this fell off your radar 🙏 |
|
Sorry about that! Don't forget to remove your try_task_config before merging. |
Codecov Report
@@ Coverage Diff @@
## master #18191 +/- ##
============================================
- Coverage 33.27% 33.26% -0.01%
Complexity 1417 1417
============================================
Files 461 461
Lines 19532 19533 +1
Branches 3011 3011
============================================
- Hits 6499 6498 -1
- Misses 12196 12197 +1
- Partials 837 838 +1
Continue to review full report at Codecov.
|
|
This pull request has conflicts when rebasing. Could you fix it @isabelrios? 🙏 |
isabelrios
force-pushed
the
taskgraph-changes-to-run-ui-tests-on-nightly-builds
branch
from
5a79b4d
to
ae73bc6
Compare
…a-mobile#18191) * Modify taskgraph to allow running UI tests on Nightly builds * adding try_task_config file * remove try_task_config file
Following comments on PR we are going to try a new approach to be able to have UI tests running on Nightly builds.
Currently only unit tests check the Nightly build generated. Having UI tests running for this build would be an extra/double check nice to have for Nightly builds.
This is something we should have at some point to prevent issues that UI tests could detect in master before Nightly build is created. For example comment on PR