Updates Fenix taskcluster tasks to support beta release #1893

mitchhentges · 2019-04-22T18:10:36Z

This depends on:

Pull Request checklist

Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
Changelog: This PR includes a changelog entry or does not need one
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

JohanLorenzo

LGTM overall. I like the way beta is supported! I found some discrepancies between .taskcluster.yml and decision.py. No big deal as they would be caught by a staging release/nightly.

automation/taskcluster/decision_task.py

.taskcluster.yml

automation/taskcluster/lib/tasks.py

mitchhentges · 2019-04-29T13:19:39Z

.taskcluster.yml

+                metadata:
+                  name: Fenix - Decision task
+                  description: Schedules the build and test tasks for Fenix.
+        - $if: 'tasks_for == "github-release"'


Note that right now, any github release is assumed to be beta.
As we get closer to the Fenix Preview release, I'll add a parse check to see if the tag has -beta.* on it

JohanLorenzo

r+ \o/
Let's fix the colliding Treeherder symbols before landing, though.

JohanLorenzo · 2019-04-29T13:11:23Z

.taskcluster.yml

+                      && python automation/taskcluster/decision_task.py beta ${event.release.tag_name}
+                extra:
+                  treeherder:
+                    symbol: B


Nit: B might be confused with "build", for people who come from mozilla-central. We might want to go with beta. I'm fine changing N, for the sake of consistency.

Good point!

I'm fine changing N, for the sake of consistency.

As in changing N to nightly, right?

JohanLorenzo · 2019-04-29T13:12:30Z

app/build.gradle

@@ -25,8 +27,8 @@ android {
        applicationId "org.mozilla.fenix"
        minSdkVersion Config.minSdkVersion
        targetSdkVersion Config.targetSdkVersion
-        versionCode Config.versionCode
-        versionName Config.versionName + Config.generateVersionSuffix()
+        versionCode 1


Nit: do we still want to keep versionCode 1. My understanding was that very first APK has already been uploaded to Google Play.

You're right that the first APK has already been uploaded to Google Play.
Config.versionCode used to just be 1, so I'm just inlining that value to the one place it's used (here) so it's more obvious at-a-glance.

Note that this is overridden separately here for release builds :)

app/build.gradle

JohanLorenzo · 2019-04-29T13:13:11Z

app/build.gradle

@@ -387,4 +409,4 @@ task printGeckoviewVersions {

 // Normally this should use the same version as the glean dependency. But since we are currently using AC snapshots we
 // can't reference a git tag with a specific version here. So we are just using "master" and hoping for the best.
-apply from: 'https://github.com/mozilla-mobile/android-components/raw/master/components/service/glean/scripts/sdk_generator.gradle'
+apply from: 'https://github.com/mozilla-mobile/android-components/raw/master/components/service/glean/scripts/sdk_generator.gradle'


Is this something that should be addressed? I think that *nix prefers there to be an EOL at EOF, but Windows doesn't care. See this point.

Mildly-relevant side-note: some of my tools automatically add a line to EOF, and I don't want to hunt them down and disable 'em :P
Are you ok with leaving this in?

automation/taskcluster/decision_task.py

automation/taskcluster/lib/tasks.py

JohanLorenzo · 2019-04-29T13:17:47Z

automation/taskcluster/lib/tasks.py

@@ -409,17 +415,17 @@ def craft_nightly_signing_task(
                'machine': {
                  'platform': 'android-all',
                },
-                'symbol': 'Ns',
+                'symbol': '{}s'.format(capitalized_build_type[0]),


If I understand correctly, beta would show up as Bs, right? I don't mean to BS you, but that symbol is already used in mozilla-central for build-signing. I'd prefer to not overload that symbol, if people familiar with Treeherder on m-c go to Fenix.

How about BeS or beta-s ?

beta-s sounds great!

mitchhentges · 2019-05-06T16:40:13Z

mitchhentges requested a review from JohanLorenzo April 22, 2019 18:10

ghost assigned mitchhentges Apr 22, 2019

ghost added the review label Apr 22, 2019

mitchhentges mentioned this pull request Apr 22, 2019

Updates Fenix taskcluster tasks to support beta release #1765

Closed

3 tasks

mitchhentges force-pushed the beta-automation branch from 4400e20 to f4e79d2 Compare April 22, 2019 18:12

JohanLorenzo approved these changes Apr 23, 2019

View reviewed changes

mitchhentges force-pushed the beta-automation branch 9 times, most recently from e8708d9 to 3d27522 Compare April 26, 2019 15:35

mitchhentges requested review from JohanLorenzo and removed request for JohanLorenzo April 29, 2019 12:43

mitchhentges force-pushed the beta-automation branch from 3d27522 to d49c798 Compare April 29, 2019 12:51

mitchhentges requested a review from JohanLorenzo April 29, 2019 12:51

mitchhentges marked this pull request as ready for review April 29, 2019 12:59

mitchhentges requested review from a team as code owners April 29, 2019 12:59

mitchhentges commented Apr 29, 2019

View reviewed changes

JohanLorenzo approved these changes Apr 29, 2019

View reviewed changes

mitchhentges force-pushed the beta-automation branch 2 times, most recently from 2dbc325 to 618fa05 Compare April 29, 2019 13:55

mitchhentges mentioned this pull request May 1, 2019

Setup a Beta Build Variant #1725

Closed

mitchhentges force-pushed the beta-automation branch 2 times, most recently from aab01a8 to fb8f3a4 Compare May 6, 2019 15:41

Updates Fenix taskcluster tasks to support beta release

b2480cc

Mitchell Hentges added 2 commits May 6, 2019 17:42

Throw error if -PversionName isn't set for release builds

3738e78

Uses beta secrets for beta

fafe9b8

mitchhentges force-pushed the beta-automation branch 4 times, most recently from 8386d19 to b457f7a Compare May 6, 2019 15:58

Improves nightly and beta treeherder symbols

e60941d

mitchhentges force-pushed the beta-automation branch from 1274079 to e60941d Compare May 6, 2019 16:46

mitchhentges merged commit 282ad31 into mozilla-mobile:master May 6, 2019

mitchhentges deleted the beta-automation branch May 6, 2019 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates Fenix taskcluster tasks to support beta release #1893

Updates Fenix taskcluster tasks to support beta release #1893

mitchhentges commented Apr 22, 2019 •

edited

Loading

JohanLorenzo left a comment

mitchhentges Apr 29, 2019

JohanLorenzo left a comment

JohanLorenzo Apr 29, 2019

mitchhentges Apr 29, 2019

JohanLorenzo Apr 29, 2019

JohanLorenzo Apr 29, 2019

mitchhentges Apr 29, 2019

JohanLorenzo Apr 29, 2019

mitchhentges Apr 29, 2019

JohanLorenzo Apr 29, 2019

mitchhentges Apr 29, 2019

mitchhentges commented May 6, 2019

Updates Fenix taskcluster tasks to support beta release #1893

Updates Fenix taskcluster tasks to support beta release #1893

Conversation

mitchhentges commented Apr 22, 2019 • edited Loading

Pull Request checklist

JohanLorenzo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JohanLorenzo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitchhentges commented May 6, 2019

mitchhentges commented Apr 22, 2019 •

edited

Loading