This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fix case of item extras in browser_menu_action event #19487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the event description to match the values observed in telemetry.
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
app/metrics.yaml
Outdated
Comment on lines
208
to
211
| add_to_homescreen, add_to_top_sites, addons_manager, back, bookmark, bookmarks, desktop_view_off, | ||
| desktop_view_on, downloads, find_in_page, forward, help, history, library, new_private_tab, new_tab, | ||
| open_in_app, open_in_fenix, quit, reader_mode_appearance, reader_mode_off, reader_mode_on, reload, | ||
| save_to_collection, set_default_browser, settings, share, stop, sync_account, and sync_tabs. |
There was a problem hiding this comment.
This actually needs changes. We're hitting the character per line limit of 80 with the glean parser, which is why you see CI builds are failing.
ERROR running glean_parser v2.2.0
Sorry, Glean found some glinter nits:
/home/runner/work/fenix/fenix/app/metrics.yaml (208:81) - line too long (107 > 80 characters) (line-length)
/home/runner/work/fenix/fenix/app/metrics.yaml (209:81) - line too long (110 > 80 characters) (line-length)
/home/runner/work/fenix/fenix/app/metrics.yaml (210:81) - line too long (108 > 80 characters) (line-length)
/home/runner/work/fenix/fenix/app/metrics.yaml (211:81) - line too long (102 > 80 characters) (line-length)
gabrielluong
added
the
pr:needs-landing
3 tasks
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 10, 2021
…19487) * Fix case of item extras in browser_menu_action event Update the event description to match the values observed in telemetry. * Line length
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the event description to match the values observed in telemetry.
No tests: not a functional change
No screenshots: not user-visible
No accessibility impacts: not user-visible
Pull Request checklist
To download an APK when reviewing a PR: