This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #19801 - Run taskgraph generation with Python 3 #19802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
taskgraph_py3
branch
5 times, most recently
from
1747db7
to
7ce9e3a
Compare
ahal
changed the title
We need to explicitly set the Java version as Java 11 now co-exists in the decision-mobile image.
Codecov Report
@@ Coverage Diff @@
## master #19802 +/- ##
============================================
- Coverage 35.75% 35.74% -0.02%
Complexity 1648 1648
============================================
Files 545 545
Lines 21903 21952 +49
Branches 3268 3274 +6
============================================
+ Hits 7831 7846 +15
- Misses 13168 13202 +34
Partials 904 904
Continue to review full report at Codecov.
|
|
Note this PR could possibly break CI (as taskgraph behaviour on non-PRs is different), so I'm going to co-ordinate with #releaseduty-mobile to land (please don't land on my behalf). |
|
This looks good to me! I can stamp closer to when we're ready to land. |
escapewindow
approved these changes
Jun 9, 2021
grigoryk
pushed a commit
to grigoryk/fenix
that referenced
this pull request
Jun 15, 2021
…zilla-mobile#19802) * For mozilla-mobile#19801 - Update to latest version of taskgraph * For mozilla-mobile#19801 - Update to latest decision-mobile image We need to explicitly set the Java version as Java 11 now co-exists in the decision-mobile image. * For mozilla-mobile#19801 - Run decision task with Python 3
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 11, 2021
…zilla-mobile#19802) * For mozilla-mobile#19801 - Update to latest version of taskgraph * For mozilla-mobile#19801 - Update to latest decision-mobile image We need to explicitly set the Java version as Java 11 now co-exists in the decision-mobile image. * For mozilla-mobile#19801 - Run decision task with Python 3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will involve updating to the latest taskgraph and decision-mobile image.