Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

CI for Docs: Add extra context to events.browser_menu_action #21696

Merged
merged 2 commits into from
Oct 4, 2021
Merged

CI for Docs: Add extra context to events.browser_menu_action #21696

merged 2 commits into from
Oct 4, 2021

Conversation

eliserichards
Copy link
Contributor

CI for #21209

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards requested review from a team as code owners October 4, 2021 18:51
@eliserichards eliserichards mentioned this pull request Oct 4, 2021
Closed
3 tasks
@eliserichards eliserichards self-assigned this Oct 4, 2021
@eliserichards
Copy link
Contributor Author

@Mergifyio rebase

@wlach
Docs only: Add extra context to events.browser_menu_action
f4f767c 
This came up as a potential point of confusion in a discussion with DS. This is a docs only change.
@wlach
Update metrics.yaml
3cc630f
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2021

Command rebase: success

Branch has been successfully rebased

@eliserichards eliserichards added the pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] label Oct 4, 2021
@eliserichards eliserichards added this to the 94 milestone Oct 4, 2021
@mergify mergify bot merged commit e2c9d9a into mozilla-mobile:main Oct 4, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Mar 7, 2022
@eliserichards @wlach @pkirakosyan
CI for Docs: Add extra context to events.browser_menu_action (mozilla…
078e08c 
…-mobile#21696)

* Docs only: Add extra context to `events.browser_menu_action`

This came up as a potential point of confusion in a discussion with DS. This is a docs only change.

* Update metrics.yaml

Co-authored-by: Will Lachance <wrlach@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonalmeida jonalmeida jonalmeida approved these changes

Assignees

@eliserichards eliserichards

Labels
pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify]
Projects
None yet
Milestone
94
Development

Successfully merging this pull request may close these issues.
3 participants
@eliserichards @jonalmeida @wlach