This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fixes #1566, #2076 #2194
Merged
Fixes #1566, #2076 #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colintheshots
approved these changes
May 2, 2019
JohanLorenzo
approved these changes
May 2, 2019
| routes = [] | ||
| if self.repo_url == _OFFICIAL_REPO_URL: | ||
| routes = [ | ||
| 'index.project.mobile.fenix.v2.branch.master.revision.{}.{}.{}'.format( | ||
| self.commit, build_type, architecture | ||
| self.commit, 'raptor', architecture |
There was a problem hiding this comment.
Okay to land these breaking changes because appending .raptor to the package name already breaks the harness. Thank you, @mitchhentges, for telling me this offline
mitchhentges
force-pushed
the
release-raptor-rename
branch
2 times, most recently
from
97d51c6
to
60c52d1
Compare
mitchhentges
force-pushed
the
release-raptor-rename
branch
from
60c52d1
to
d7bbce6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this changes:
gradlecommand from./gradlew assembleReleaseRaptorto./gradlew assembleRaptororg.mozilla.fenixtoorg.mozilla.fenix.raptor(note:--binaryis updated as part of this PR to use the new ID)release-raptorreplaced withraptorPull Request checklist