This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fix-misnamed TC artifacts, partially-address #2211 #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchhentges
force-pushed
the
master
branch
2 times, most recently
from
c2ed67d
to
e11df90
Compare
|
Don't mind the taskcluster failures, they're mad because I've enabled Taskcluster with my local repo, but I've removed the " |
This was referenced May 3, 2019
colintheshots
approved these changes
May 4, 2019
JohanLorenzo
approved these changes
May 6, 2019
automation/taskcluster/lib/tasks.py
Outdated
| @@ -582,7 +581,7 @@ def _craft_artifacts_from_variant(variant): | |||
|
|
|||
| def _craft_apk_full_path_from_variant(variant): | |||
| architecture, build_type = get_architecture_and_build_type_from_variant(variant) | |||
| postfix = '-unsigned' if build_type.startswith('release') else '' | |||
| postfix = '' if build_type == 'Debug' else '-unsigned' | |||
There was a problem hiding this comment.
Do you confirm Raptor has now variant in ('armRaptor', 'aarch64Raptor) which means:
architecture in ('arm', 'aarch64')build_type == 'Raptor'
Therefore, a raptor build ends with -unsigned.apk, right?
There was a problem hiding this comment.
Note: good point on checking the build_type, it is lowercased from get_arch_and..., so I should be checking "Debug". I'll run a new build and double-check the results
Otherwise, the new $archRaptor have builds that end in -unsigned, exactly :)
$ ./gradlew printBuildVarients
variants: ["aarch64Raptor","aarch64Debug","aarch64Nightly","aarch64Beta","x86Raptor","x86Debug","x86Nightly","x86Beta","armRaptor","armDebug","armNightly","armBeta"]
|
... Just remembered that this PR was from my |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-build task group here
This will properly populate the Fenix index again.
Unfortunately, this PR doesn't handle the specific issue in the linked build of #2211
Pull Request checklist