Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Renew/remove metrics set to expire in March 2022 #23783

Merged
merged 1 commit into from
Feb 17, 2022
Merged

No issue: Renew/remove metrics set to expire in March 2022 #23783

merged 1 commit into from
Feb 17, 2022

Conversation

rocketsroger
Copy link
Contributor

@rocketsroger rocketsroger commented Feb 16, 2022 •
edited
Loading

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rocketsroger rocketsroger requested review from a team as code owners February 16, 2022 16:43
@rocketsroger rocketsroger added needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels Feb 16, 2022
@rocketsroger
Copy link
Contributor Author

Request for Data Collection Renewal

Renew for 1 year

Total: 2
———
progressive_web_app.homescreen_tap:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 2023-03-31

  3. Why was the initial period of collection insufficient?

    • key metric to understand PWA usage

———
progressive_web_app.install_tap:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 2023-03-31

  3. Why was the initial period of collection insufficient?

    • key metric to understand PWA usage

———

MozillaNoah
MozillaNoah approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engineering r+

@eliserichards
Copy link
Contributor

Request for Data Collection Renewal

Renew for 1 year

Total: 2 ——— progressive_web_app.homescreen_tap:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #10261: PWA Telemetry #11859](https://github.com/mozilla-mobile/fenix/pull/11859)

2. When will this collection now expire?
   
   * 2023-03-31

3. Why was the initial period of collection insufficient?
   
   * key metric to understand PWA usage

——— progressive_web_app.install_tap:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #10261: PWA Telemetry #11859](https://github.com/mozilla-mobile/fenix/pull/11859)

2. When will this collection now expire?
   
   * 2023-03-31

3. Why was the initial period of collection insufficient?
   
   * key metric to understand PWA usage

Data Collection Renewal Review (to be filled by Data Stewards)

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

    • Yes

  2. Is the data collection covered by the existing Firefox Privacy Notice?

    • Yes

Result

data-review+

eliserichards
eliserichards approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-review+

@eliserichards eliserichards removed the needs:data-review PR is awaiting a data review label Feb 16, 2022
@rocketsroger rocketsroger added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Feb 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2022

This pull request has conflicts when rebasing. Could you fix it @rocketsroger? 🙏

@rocketsroger rocketsroger removed pr:needs-landing PRs that are ready to land [Will be merged by Mergify] needs:review PRs that need to be reviewed labels Feb 16, 2022
@rocketsroger rocketsroger added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Feb 17, 2022
@gabrielluong gabrielluong merged commit 7dc9691 into mozilla-mobile:main Feb 17, 2022
@rocketsroger rocketsroger deleted the march_2022_telemetry_renewal branch February 17, 2022 01:02
@rocketsroger
Copy link
Contributor Author

@Mergifyio backport releases_v98.0.0

@mergify mergify bot mentioned this pull request Feb 17, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2022

backport releases_v98.0.0

✅ Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MozillaNoah MozillaNoah MozillaNoah approved these changes

@eliserichards eliserichards eliserichards approved these changes

Assignees
No one assigned
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rocketsroger @eliserichards @MozillaNoah @gabrielluong