Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Disable failing openExternalLinksInPrivateTest UI test #25082

Merged

Conversation

AndiAJ
Copy link
Collaborator

@AndiAJ AndiAJ commented May 3, 2022

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@AndiAJ AndiAJ requested review from a team as code owners May 3, 2022 11:58
@AndiAJ AndiAJ self-assigned this May 3, 2022
@AndiAJ AndiAJ added the eng:ui-test UI Tests label May 3, 2022
@AndiAJ AndiAJ requested a review from sv-ohorvath May 3, 2022 11:58
@AndiAJ AndiAJ added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label May 3, 2022
@mergify mergify bot merged commit f3aee69 into mozilla-mobile:main May 3, 2022
@AndiAJ AndiAJ deleted the disableOpenExternalLinksInPrivateTest branch May 3, 2022 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:ui-test UI Tests pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants