Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #26792 - Change active Firebase Test Lab emulator from x86 to ARM #26793

Merged
merged 5 commits into from
Sep 14, 2022
Merged

For #26792 - Change active Firebase Test Lab emulator from x86 to ARM #26793

merged 5 commits into from
Sep 14, 2022

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Sep 2, 2022 •
edited
Loading

See #26792

Contains test fixes and cleanup too.

@AaronMT AaronMT self-assigned this Sep 2, 2022
@AaronMT AaronMT mentioned this pull request Sep 6, 2022
Closed
@mozilla-mobile mozilla-mobile deleted a comment from mergify bot Sep 6, 2022
@AaronMT
Copy link
Contributor Author

AaronMT commented Sep 6, 2022 •
edited
Loading

@JohanLorenzo Hey Johan, I have couple questions prior to review. Since this PR is mainly renaming and cleaning up our configurations/jobs for ARM, is the lingering expected Check on this PR ui-test-x86-debug just a cache thing? If not, where might that Check be coming from still (it's not listed in under Checks and not in the Decision Task)? Also in Mergify checks here there are some references to ui-test-x86-debug, since I am renaming this to ARM, where are those rules coming from (repository settings?)? Just making sure things are renamed.

@JohanLorenzo
Copy link
Contributor

Hey!

is the lingering expected Check on this PR ui-test-x86-debug just a cache thing?

That is a good question. Actually, it's not. The list of expected Github checks is defined in the repo settings. Only an admin of the repo is able to make these changes through the web UI. I know @amedyne can, for instance.

Also in Mergify checks here there are some references to ui-test-x86-debug, since I am renaming this to ARM, where are those rules coming from (repository settings?)?

On the hand, Mergify is defined as code in this repo[1]. The good news is: we don't reference jobs one by one there. Instead, we rely on the jobs complete-pr/complete-push. They ensure all the expected jobs are green. I think there won't be any changes needed there.

Side note: if, for whatever reason, you need to modify .mergify.yml, you will have to merge your PR manually because the changes are only taken into account once they reach main.

[1] https://github.com/mozilla-mobile/fenix/blob/d4b6babdb0e0fd7384c6cca8a511e9dc1032b865/.mergify.yml

@AaronMT AaronMT force-pushed the FTL-x86-to-ARM branch 5 times, most recently from 6658839 to 2969598 Compare September 8, 2022 15:56
@mergify

This comment was marked as resolved.

Sign in to view
@mergify

This comment was marked as resolved.

Sign in to view
@AaronMT AaronMT force-pushed the FTL-x86-to-ARM branch 3 times, most recently from cd679b8 to 3385477 Compare September 12, 2022 15:26
@AaronMT AaronMT marked this pull request as ready for review September 12, 2022 15:26
@AaronMT AaronMT requested review from a team as code owners September 12, 2022 15:26
@AaronMT AaronMT requested review from hneiva, AndiAJ and JohanLorenzo and removed request for a team September 12, 2022 15:26
@AaronMT
Copy link
Contributor Author

AaronMT commented Sep 12, 2022 •
edited
Loading

@AndiAJ feel free to review the test changes and @JohanLorenzo the kind.yml & Flank configurations (and to make sure I'm not missing a rename somewhere)
@jcristau mentioned on Slack that this will require updating repo check of ui-test-x86-debug to ui-test-arm-debug

Note: There's currently a 50 shard limit on the new ARM emulator reflected in the parameter passing/setting.

@mergify

This comment was marked as resolved.

Sign in to view
JohanLorenzo
JohanLorenzo approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the taskcluster folder all look good to me!

@AaronMT AaronMT force-pushed the FTL-x86-to-ARM branch 3 times, most recently from 93c1cd8 to b269d83 Compare September 13, 2022 17:44
@AaronMT
For mozilla-mobile#26792 - Change active Firebase Test Lab emulator f…
41a5242 
…rom x86 to ARM

Update startup-test kind.yml Jobs for ARM
Update ui-test kind.yml Jobs for ARM
Cleans up and renames Flank configurations for ARM
Updates ui-test.sh for ARM
@AaronMT
Fix BookmarksTest.kt and HomeScreenTest.kt
149f15e
@AaronMT
Fix intent matcher for SettingsAboutTest
ec9abf1 
Adds a helper function for Play Store intent
@AaronMT
Fix SettingsSearchTest.kt
b6faa4d
@AaronMT
ktlint fix TestHelper.kt and SettingsRobot.kt
54aca9a
@jcristau jcristau merged commit 4e99fe8 into mozilla-mobile:main Sep 14, 2022
This was referenced Sep 21, 2022
Closed
Closed
@AaronMT AaronMT deleted the FTL-x86-to-ARM branch September 25, 2022 02:22
This was referenced Oct 18, 2022
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this pull request Feb 14, 2023
@AaronMT
[fenix] For mozilla-mobile/fenix#26792 - Change active Firebase Test …
02701aa 
…Lab emulator from x86 to ARM (mozilla-mobile/fenix#26793)

* For mozilla-mobile/fenix#26792 - Change active Firebase Test Lab emulator from x86 to ARM

Update startup-test kind.yml Jobs for ARM
Update ui-test kind.yml Jobs for ARM
Cleans up and renames Flank configurations for ARM
Updates ui-test.sh for ARM

* Fix BookmarksTest.kt and HomeScreenTest.kt

* Fix intent matcher for SettingsAboutTest

Adds a helper function for Play Store intent

* Fix SettingsSearchTest.kt

* ktlint fix TestHelper.kt and SettingsRobot.kt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohanLorenzo JohanLorenzo JohanLorenzo approved these changes

@AndiAJ AndiAJ AndiAJ approved these changes

@hneiva hneiva Awaiting requested review from hneiva hneiva is a code owner automatically assigned from mozilla-mobile/releng

Assignees

@AaronMT AaronMT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronMT @JohanLorenzo @AndiAJ @jcristau