Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #2770: Allow receiving tabs from FxA devices #2772

Merged
merged 2 commits into from
May 23, 2019

Conversation

grigoryk
Copy link
Contributor

Now that we're on a-c 0.54, we can land this since it supports device
capability migration.

This patch adds a SEND_TAB device capability, making Fenix a valid target
in the Send Tab device list on Desktop Firefox.

Additionally, it adds a notification manager which manages notification
channels and knows how to display "received tabs" notifications".

Currently, device events are refreshed every 15 minutes in the background worker.
Additionally, they can be polled manually via "Sync Now" in account settings.

Once push integration lands as part of #246, tabs will be received nearly instantly.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not

The part that could benefit from unit tests here is the notification manager, but I'm not sure how to unit test it.

Notifications are plaintext, which I'm assuming will play nicely with the screen readers.

Screenshots

Receiving multiple tabs

Screenshot_1558598428
Screenshot_1558598452

App notification system settings (i.e. how strings added in this PR will appear):

Screenshot_1558598084
Screenshot_1558598092

@grigoryk grigoryk requested a review from a team as a code owner May 23, 2019 08:05
@grigoryk
Copy link
Contributor Author

In the screenshots you'll notice that the notification is missing the icon (to the left of the app name). I'm not sure why that is - I'm specifying ic_notification, which seems like a valid icon..?

Now that we're on a-c 0.54, we can land this since it supports device
capability migration.

This patch adds a SEND_TAB device capability, making Fenix a valid target
in the Send Tab device list on Desktop Firefox.

Additionally, it adds a notification manager which manages notification
channels and knows how to display "received tabs" notifications".
@boek boek merged commit 6a8d0f3 into mozilla-mobile:master May 23, 2019
@grigoryk grigoryk deleted the receiveTabs branch May 23, 2019 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants