This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes #2770: Allow receiving tabs from FxA devices #2772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're on a-c 0.54, we can land this since it supports device
capability migration.
This patch adds a SEND_TAB device capability, making Fenix a valid target
in the Send Tab device list on Desktop Firefox.
Additionally, it adds a notification manager which manages notification
channels and knows how to display "received tabs" notifications".
Currently, device events are refreshed every 15 minutes in the background worker.
Additionally, they can be polled manually via "Sync Now" in account settings.
Once push integration lands as part of #246, tabs will be received nearly instantly.
Pull Request checklist
The part that could benefit from unit tests here is the notification manager, but I'm not sure how to unit test it.
Notifications are plaintext, which I'm assuming will play nicely with the screen readers.
Screenshots
Receiving multiple tabs
App notification system settings (i.e. how strings added in this PR will appear):