This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Import strings from android-l10n #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
approved these changes
Jul 17, 2019
| @@ -23,7 +23,7 @@ | |||
| <!-- Explanation for private browsing displayed to users on home view when they first enable private mode | |||
| The first parameter is the name of the app defined in app_name (for example: Fenix) --> | |||
| <string name="private_browsing_explanation">%1$s borra tus búsquedas e historial de navegación cuando cierras una sesión privada | |||
| Aunque no te hace anónimo para los sitios web o proveedor de servicios de Internet, | |||
| Aunque no te hace anónimo para los sitios web o proveedor de servicios de Internet, | |||
|
|
||
| <!-- Text to tell the user how many more tabs this session has. | ||
| The first parameter is a digit that shows the cardinal number of how many additional tabs the session has. --> | ||
| <string name="session_items_more">%1$d siti...</string> |
There was a problem hiding this comment.
Nit: use ellipsis (…) instead of three periods (...).
| <string name="session_item_delete">削除</string> | ||
| <!-- Text to tell the user how many more tabs this session has. | ||
| The first parameter is a digit that shows the cardinal number of how many additional tabs the session has. --> | ||
| <string name="session_items_more">%1$d サイト…</string> |
| 사용자가 제어할 수 있게 만들었습니다. | ||
|
|
||
| <!-- Text for the button to delete a single session --> | ||
| <string name="session_item_delete">Ta bort</string> | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: too many blank lines.
| @@ -605,7 +611,7 @@ | |||
|
|
|||
|
|
|||
| <!-- Sample text for accessibility font size --> | |||
| <string name="accessibility_text_size_sample_text">The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. | |||
| <string name="accessibility_text_size_sample_text">The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. | |||
There was a problem hiding this comment.
Nit: can we use two differing pangrams, instead of repeating the same one twice?
The five boxing wizards jump quickly.
Pack my box with five dozen liquor jugs.
How quickly daft jumping zebras vex.
More seriously, I note that the this appears in the zh-rCN strings file, but isn't translated.
| @@ -597,7 +602,7 @@ | |||
|
|
|||
|
|
|||
| <!-- Sample text for accessibility font size --> | |||
| <string name="accessibility_text_size_sample_text">The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. | |||
| <string name="accessibility_text_size_sample_text">The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. | |||
There was a problem hiding this comment.
Again, similar problems: trailing space, and isn't translated.
|
Going to land this and follow up with l10n 👍 |
|
Moving conversation here for the sack of openness. I suggest that we either:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State: mozilla-l10n/android-l10n@e521a2a
This adds new locales to the config, and the first translations for Swedish.
CC @Delphine