Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Upload Fenix Nightly to Nimbledroid #4222 #4253

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Upload Fenix Nightly to Nimbledroid #4222 #4253

merged 1 commit into from
Aug 2, 2019

Conversation

kglazko
Copy link
Contributor

@kglazko kglazko commented Jul 23, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@kglazko kglazko requested review from a team as code owners July 23, 2019 20:43
@kglazko kglazko removed request for a team July 23, 2019 20:43
@kglazko kglazko force-pushed the DONOTMERGENimbledroid branch 2 times, most recently from 32f2f5f to b1275bf Compare August 1, 2019 19:18
nojunpark
nojunpark approved these changes Aug 1, 2019
View reviewed changes
Copy link

@nojunpark nojunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe extra line break for lint purpose?

nojunpark
nojunpark reviewed Aug 1, 2019
View reviewed changes
automation/taskcluster/upload_apk_nimbledroid.py Outdated
data = secrets.get('project/mobile/fenix/nimbledroid')

# upload the nightly build to Nimbledroid
uploadNightlyFenixApk(data['secret']['api_key'])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line here?

rpappalax
rpappalax approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@rpappalax rpappalax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the failing job is passing, looks good to me 👍

@kglazko kglazko changed the title [WIP DO NOT MERGE] Upload Fenix Nightly to Nimbledroid #4222 Upload Fenix Nightly to Nimbledroid #4222 Aug 1, 2019
@kglazko kglazko force-pushed the DONOTMERGENimbledroid branch 2 times, most recently from c1e1b8c to b9bf041 Compare August 2, 2019 15:46
@kglazko kglazko merged commit 46b2d6f into master Aug 2, 2019
@JohanLorenzo
Copy link
Contributor

FYI: A missing scope broke the nightly task. More information at https://bugzilla.mozilla.org/show_bug.cgi?id=1571452

@boek boek deleted the DONOTMERGENimbledroid branch September 4, 2019 16:20
@boek boek restored the DONOTMERGENimbledroid branch September 4, 2019 16:21
@boek boek deleted the DONOTMERGENimbledroid branch September 11, 2019 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nojunpark nojunpark nojunpark approved these changes

@rpappalax rpappalax rpappalax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kglazko @JohanLorenzo @rpappalax @nojunpark