Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #964: Adds ability to disable each suggestion provider #5096

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Sep 3, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

image

@sblatz sblatz requested review from a team as code owners September 3, 2019 20:01
@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #5096 into master will decrease coverage by 0.06%.
The diff coverage is 20.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #5096      +/-   ##
===========================================
- Coverage      8.87%   8.81%   -0.07%     
+ Complexity      195     192       -3     
===========================================
  Files           234     231       -3     
  Lines          9224    9169      -55     
  Branches       1334    1332       -2     
===========================================
- Hits            819     808      -11     
+ Misses         8351    8308      -43     
+ Partials         54      53       -1
Impacted Files Coverage Δ Complexity Δ
...va/org/mozilla/fenix/components/metrics/Metrics.kt 18.33% <ø> (+0.1%) 0 <0> (ø) ⬇️
...org/mozilla/fenix/settings/SearchEngineFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...lla/fenix/components/toolbar/ToolbarIntegration.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../mozilla/fenix/search/awesomebar/AwesomeBarView.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/mozilla/fenix/search/SearchFragmentStore.kt 63.63% <0%> (-4.11%) 1 <0> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 80.8% <100%> (+1.23%) 15 <0> (ø) ⬇️
app/src/main/java/org/mozilla/fenix/ext/Session.kt 12.5% <0%> (-1.79%) 0% <0%> (ø)
...in/java/org/mozilla/fenix/share/ShareController.kt 79.31% <0%> (-1.46%) 0% <0%> (ø)
...a/org/mozilla/fenix/settings/TurnOnSyncFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd9e44...72fa36e. Read the comment docs.

@sblatz sblatz force-pushed the disable-suggestion-providers branch from ea45d86 to 488f757 Compare September 3, 2019 20:17
@@ -91,8 +91,10 @@ class SearchFragment : Fragment(), BackHandler {
showShortcutEnginePicker = displayShortcutEnginePicker,
searchEngineSource = currentSearchEngine,
defaultEngineSource = currentSearchEngine,
showSuggestions = Settings.getInstance(requireContext()).showSearchSuggestions,
showVisitedSitesBookmarks = Settings.getInstance(requireContext()).shouldShowVisitedSitesBookmarks,
showSuggestions = Settings.getInstance(requireContext()).shouldShowSearchSuggestions,
Copy link
Contributor

@jyeontaek jyeontaek Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a nit, I think we should take this opportunity to rename showSuggestions to showSearchSuggestions just to make it a bit clearer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point--in fact the kdoc comment above it even specifies it's a search suggestion not just a suggestion. Updated 😄

@sblatz sblatz force-pushed the disable-suggestion-providers branch from e1b2819 to 72fa36e Compare September 5, 2019 21:31
@sblatz sblatz merged commit 2653b59 into mozilla-mobile:master Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants