-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #964: Adds ability to disable each suggestion provider #5096
For #964: Adds ability to disable each suggestion provider #5096
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5096 +/- ##
===========================================
- Coverage 8.87% 8.81% -0.07%
+ Complexity 195 192 -3
===========================================
Files 234 231 -3
Lines 9224 9169 -55
Branches 1334 1332 -2
===========================================
- Hits 819 808 -11
+ Misses 8351 8308 -43
+ Partials 54 53 -1
Continue to review full report at Codecov.
|
ea45d86
to
488f757
Compare
@@ -91,8 +91,10 @@ class SearchFragment : Fragment(), BackHandler { | |||
showShortcutEnginePicker = displayShortcutEnginePicker, | |||
searchEngineSource = currentSearchEngine, | |||
defaultEngineSource = currentSearchEngine, | |||
showSuggestions = Settings.getInstance(requireContext()).showSearchSuggestions, | |||
showVisitedSitesBookmarks = Settings.getInstance(requireContext()).shouldShowVisitedSitesBookmarks, | |||
showSuggestions = Settings.getInstance(requireContext()).shouldShowSearchSuggestions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a nit, I think we should take this opportunity to rename showSuggestions
to showSearchSuggestions
just to make it a bit clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point--in fact the kdoc comment above it even specifies it's a search suggestion
not just a suggestion
. Updated 😄
e1b2819
to
72fa36e
Compare
Pull Request checklist