Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5197: Adds telemetry for media controls #5266

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Sep 12, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

@sblatz sblatz requested review from a team as code owners September 12, 2019 17:42
@sblatz sblatz added the needs:data-review PR is awaiting a data review label Sep 12, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Sep 12, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often users interact with media controls
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • Usefulness of media controls
  • How often users use the browser to play media? This helps us prioritize media related bugs and features?
  • How often users have multiple open tabs playing media
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 03/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #5266 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5266      +/-   ##
============================================
- Coverage     12.76%   12.75%   -0.01%     
  Complexity      277      277              
============================================
  Files           251      251              
  Lines         10328    10336       +8     
  Branches       1504     1506       +2     
============================================
  Hits           1318     1318              
- Misses         8921     8929       +8     
  Partials         89       89
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 0.78% <0%> (-0.02%) 1 <0> (ø)
...va/org/mozilla/fenix/components/metrics/Metrics.kt 24.48% <0%> (-0.26%) 0 <0> (ø)
...x/home/sessioncontrol/viewholders/TabViewHolder.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a9b50...57edd3b. Read the comment docs.

Copy link
Contributor

@ekager ekager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs data review. 1 nit for other code

docs/metrics.md Outdated Show resolved Hide resolved
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, documented in metrics.yaml, and generated metrics.md is included.

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Fenix data controls

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Expires in 3/2020

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, user interactions w/ media controls on the homescreen

  1. Is the data collection request for default-on or default-off?

Default on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No, just interactions w/ UI, no extras

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does there need to be a check-in in the future to determine whether to renew the data?

Has expiry

  1. Does the data collection use a third-party collection tool?

No

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants