Issue #14142 - Telemetry renewal to 08-01-2021

[liuche]

Went over remaining telemetry for renewal with Vesta/PM 10/5

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[liuche]

WIP for linking in telemetry changes

Telemetry Data Renewal request

find_in_page closed, opened

1. Provide a link to the initial Data Collection Review Request for this collection.
   Adds Telemetry for Context Menu and Find in page #1344 (comment)
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Currently redesigning menu, need to get idea of how people use find in page

history opened, opened_item, removed, removed_all, shared

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #2362: Adds telemetry for history #3940
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Need release telemetry to decide whether history should be on home screen

login_dialog, logins settings

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #9730: Add Login Dialog Prompt telemetry #13050
   For #5586 - Adds Logins Telemetry #6352
   For #10173: login duplicates and save #11208
   For #5586 - Add telemetry for save logins setting #7767
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Usage of new logins edit feature, measure login usage

media_notification, media_state`

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #5197: Adds telemetry for media notification #5520
   For #5705 - Adds telemetry for media state #6463
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Media is a focus for 2020 Q4 for improvement and usage

onboarding

1. Provide a link to the initial Data Collection Review Request for this collection.
   #10824: Onboarding telemetry #11867
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Want to see how users interact with onboarding items

pocket.pocket_top_site

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #8126 - Adds default top sites  #8098
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Important for Pocket revenue tracking

private_browsing mode and shortcut

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #4658: Add private browsing mode telemetry #4968
   For #4658: Add private browsing mode shortcut telemetry #5194
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Indicator of users leaving a private tab on and switch away from browser
   private shortcut usage compared to what might be the case in Focus
   tracks entry points to the app

private_browsing_shortcut.cfr_add_shortcut
private_browsing_shortcut.cfr_cancel

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #4658: Add private browsing mode shortcut telemetry #5194
2. When will this collection now expire? 06/01/2021
3. Why was the initial period of collection insufficient?
   Needed for CFR experiment analysis

qr_scanner

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #1857: Adds telemetry for QR scanner #2524 (comment)
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Important for prioritizing QR code bugs based on popularity/usage

reader_mode

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #2267: Adds telemetry for reader mode #3941
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Need historical reader mode usage telemetry for improving reader mode in 2021

search_shortcuts.selected

1. Provide a link to the initial Data Collection Review Request for this collection.
   Closes #1194: Adds search shortcut telemetry #1202 (comment)
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Search team would like to know whether non-google search

search_suggestions.enable_in_private

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #6070 Adds telemetry for enabling search suggestions in private #6746
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Measures user interaction with the search suggestion hints

search_widget, search_widget_cfr

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #4457: Adds telemetry for search widget actions #4714
   For #9488: Add Search widget CFR & telemetry #10958
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Prioritization of search widget feature

sync_account, sync_auth

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #1190: Adds telemetry for FxA login #2745 (comment)
   For #4908: Adds metrics for send tab telemetry #5106
   FxA WebChannels integration  #4931 (comment)
   Add 'useEmail' metrics event #9835 (review)
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Part of the question about why sync features are undiscoverable
   Measures success stages of sync

tab.media play/pause

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #5197: Adds telemetry for media controls #5266
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Media is a Q4 2020 priority

tabs_tray

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11273: Add tabs tray telemetry #12036
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   New changes to collections in tabs tray means checking for regressions in other tabs tray interactions

tip for in-product notification

1. Provide a link to the initial Data Collection Review Request for this collection.
   Issue #9208: Adds in-product prompt to homescreen #9836
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   May use this for addons, or “what’s new”

toolbar_settings.changed_position

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #5694 & #6054: Allows users to change toolbar position #6608
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Going into settings to discover/change toolbar position

top_sites

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #8125: Add default top site telemetry #10752
   For #6758 - Add Top Sites to Fenix #7523
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Measuring Top Sites new feature success

tracking_protection

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #5312 - Add Telemetry for Tracking Protection #5414 (comment)
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Deciding what to do with privacy focus on Fenix

custom_engine search engine usage

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #5884: Adds user-specified search engines telemetry #6918
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   May want to enhance custom search engine if users commonly try/fail to add custom search engines

voice_search

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #10465: Add telemetry for voice search  #10785
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Measures Search feature usage

first-session

first_session telemetry, which includes the client id

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #7295 - Adds new custom ping: 'installation' #8074 (comment)
2. When will this collection now expire? 08/01/2021
3. Why was the initial period of collection insufficient?
   Renewing to continue to be able to determine effectiveness of marketing campaigns beyond acquisition

metrics

browser.search ad_clicks, in_content, with_ads

1. Provide a link to the initial Data Collection Review Request for this collection.
   Feature/#6558 Ad click attribution #10112
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Important for revenue count

events.total_uri_count

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #6577 - total_uri_count Glean telemetry #8314
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   useful for strategy work, could be a primary success metric for fenix usage

adjust ad_group, campaign, creative, network

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #9136: Send all adjust properties to glean #9253
   For #1298: Adds adjustCampaignId to core ping #5579
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   used for attribution

default_browser, default_moz_browser, mozilla_products

1. Provide a link to the initial Data Collection Review Request for this collection.
   Backfill metrics pt. 1 #1067 (comment)
   [Waiting on Data Review] For #1192: Adds telemetry for Mozilla products #1953
   [Waiting on Data Review] For #1192: Adds telemetry for Mozilla products #1953
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Important metric for user engagement, messaging
   measure of Mozilla portfolio in the wild

has_open_tabs, tabs_open_count

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11479: Record open tabs count in metrics ping #12024
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   shapes how people use content in fenix, collections

has_recent_pwas, recently_used_pwa_count

1. Provide a link to the initial Data Collection Review Request for this collection.
   Closes #11909: Metrics for recording number of recently used PWAs #11982 (review)
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   determining future PWA investment

has_top_sites, top_sites_count

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #8125 - Send top sites count with metrics ping #9556
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   This is a new feature and need to iterate on it based on telemetry

search_count

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #1158 - Add search counts #1677
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Important for revenue tracking

search_widget_installed

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #9488: Add Search widget CFR & telemetry #10958
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   search widget has no setting, so this is the only place to know if search widget is installed

metrics.toolbar_position, preferences.toolbar_position

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #5694 & #6054: Allows users to change toolbar position #6608
   For #11118: Add toggle states to metrics ping #11211
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   informs our default setting, numbers for differentiating feature, bug prioritization

preferences (in the metrics ping)

accessibility_services

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11118: Add toggle states to metrics ping #11211
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Usage of a11y

open_links in_a_private_tab, in_app

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11118: Add toggle states to metrics ping #11211
   For #11118: Add missing telemetry #11446
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Projection of Focus competitive privacy features, may change defaults for these settings

remote_debugging

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11118: Add toggle states to metrics ping #11211
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Collection to determine investment in web debugging tools for Fenix

search
suggestions: bookmarks, browsing_history, private
show: clipboard_suggestions, search_shortcuts, search_suggestions, voice_search

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11118: Add toggle states to metrics ping #11211
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Compare what suggestions people choose to show for search

sync, sync_items

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11118: Add toggle states to metrics ping #11211
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Important for the Sync team, sync feature

telemetry

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11118: Add toggle states to metrics ping #11211
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Tracking for negatives that would indicate our telemetry opt-out is not working

theme

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #11118: Add missing telemetry #11446
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Dark theme/light fix prioritization

search.default_engine code, name, submission_url

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #800 - Adds metrics for the default search engine #1606
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Useful for the Search team

startup timeline

startup.timeline clock_ticks_per_second, framework_start, start_error, start_read_error

1. Provide a link to the initial Data Collection Review Request for this collection.
   For #8803: add frameworkStart telemetry #9788 (review)
2. When will this collection now expire? 10/01/2021
3. Why was the initial period of collection insufficient?
   Need data science support, and are working on improving startup in Q4 ‘20/Q1 ‘21

[codecov-commenter]

Codecov Report

Merging #15713 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #15713      +/-   ##
============================================
+ Coverage     29.79%   29.80%   +0.01%     
- Complexity     1180     1181       +1     
============================================
  Files           452      452              
  Lines         18395    18395              
  Branches       2376     2376              
============================================
+ Hits           5481     5483       +2     
+ Misses        12526    12524       -2     
  Partials        388      388              

Impacted Files	Coverage Δ	Complexity Δ
...mponents/searchengine/FenixSearchEngineProvider.kt	59.82% <0.00%> (+1.78%)	15.00% <0.00%> (+1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2b99f...0e63d59. Read the comment docs.

[boek]

Data Collection Renewal Review (to be filled by Data Stewards)

Instructions:
A Data Steward will use this form to review a Data Collection Renewal Request.
** If the request is incomplete,
or if the Data Steward can't answer the questions in this form,
the Steward should give a data-review-
and either instruct the requestor on how to correct the request
or involve Trust, as appropriate. **

1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?
   yes
2. Is the data collection covered by the existing Firefox Privacy Notice?
   yes

[mergify]

This pull request has conflicts when rebasing. Could you fix it @liuche? 🙏