Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #394 - Trusted Web Activities #5391

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Sep 17, 2019

Depends on mozilla-mobile/android-components#4440 and #4914

Adds support for Trusted Web Activities in Fenix nightly and debug.

Here are some apps using Trusted Web Activities we can test with:

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #5391 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5391      +/-   ##
============================================
- Coverage     14.37%   14.35%   -0.03%     
  Complexity      320      320              
============================================
  Files           257      257              
  Lines         10588    10604      +16     
  Branches       1551     1551              
============================================
  Hits           1522     1522              
- Misses         8940     8956      +16     
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/components/Components.kt 37.03% <0%> (-12.97%) 1 <0> (ø)
...a/org/mozilla/fenix/components/IntentProcessors.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../org/mozilla/fenix/customtabs/CustomTabsService.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9760fb...3cf8d20. Read the comment docs.

@NotWoods NotWoods added Feature:PWA Progressive Web App and removed pr:do-not-land labels Sep 20, 2019
@NotWoods NotWoods marked this pull request as ready for review September 20, 2019 21:12
@NotWoods NotWoods requested review from a team as code owners September 20, 2019 21:12
Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm still not seeing pull to refresh on these. Is that expected?

@NotWoods
Copy link
Contributor Author

We don't yet support pull to refresh. That's depended on the corresponding AC feature, which needs to be updated now that GeckoView has added the necessary dependency.

We're going to ask the QA team to look at this before merging as well.

@sblatz sblatz merged commit 6ec0d46 into mozilla-mobile:master Oct 9, 2019
@NotWoods NotWoods deleted the twa branch January 25, 2020 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature:PWA Progressive Web App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants