Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5197: Adds telemetry for media notification #5520

Merged
merged 1 commit into from Sep 27, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Sep 24, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested review from a team as code owners September 24, 2019 15:19
@sblatz sblatz requested a review from boek September 24, 2019 15:19
@sblatz sblatz added the needs:data-review PR is awaiting a data review label Sep 24, 2019
@boek
Copy link
Contributor

boek commented Sep 24, 2019

Do not land this until we decide which A-C version we're pinning for 2.1

@pocmo
Copy link
Contributor

pocmo commented Sep 24, 2019

Even though it may not be in the last 14.0.0-SNAPSHOT ... I'm pretty sure it made 14.0.0 release!

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #5520 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5520      +/-   ##
============================================
- Coverage     14.04%   14.03%   -0.02%     
  Complexity      311      311              
============================================
  Files           255      255              
  Lines         10414    10426      +12     
  Branches       1507     1511       +4     
============================================
  Hits           1463     1463              
- Misses         8840     8852      +12     
  Partials        111      111
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 5.51% <0%> (-0.09%) 3 <0> (ø)
...va/org/mozilla/fenix/components/metrics/Metrics.kt 25.71% <0%> (-0.89%) 0 <0> (ø)
...va/org/mozilla/fenix/onboarding/FenixOnboarding.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9c531...3b623ee. Read the comment docs.

@sblatz
Copy link
Contributor Author

sblatz commented Sep 24, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • Usefulness of media notification
  • How often users browse tabs with media
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This will help us prioritize bugs with media tickets (depending on how popular the feature is)
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • We currently record interacting with the play/pause button on the tab itself, but nothing tracks the media notification.
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 03/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@boek boek added the needs:uplift Issue / PR needs to be uplifted to the release branch label Sep 26, 2019
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in metrics.yaml and metrics.md

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Fenix data controls

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Fenix PM Vesta will monitor, and this has an expiry

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2 for interaction with the media controls

  1. Is the data collection request for default-on or default-off?

Default on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

no

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Has expiry, 3/2020

  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

@boek boek added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:data-review PR is awaiting a data review labels Sep 27, 2019
@sblatz sblatz merged commit 6babf72 into mozilla-mobile:master Sep 27, 2019
@ekager ekager removed the needs:uplift Issue / PR needs to be uplifted to the release branch label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:do-not-land pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants