For #1298: Adds adjustCampaignId to core ping #5579
For #1298: Adds adjustCampaignId to core ping #5579
Conversation
1b3a9e3
to
76afd1d
Compare
9a32437
to
37ceab3
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
37ceab3
to
1090f8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #5579 +/- ##
===========================================
+ Coverage 13.96% 14.06% +0.1%
- Complexity 308 311 +3
===========================================
Files 255 255
Lines 10438 10427 -11
Branches 1514 1506 -8
===========================================
+ Hits 1458 1467 +9
+ Misses 8863 8849 -14
+ Partials 117 111 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, in metrics.yaml and metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Fenix PM Vesta will monitor, and this has an expiry
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 1 for recording the installations source campaign ID
- Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
Adds the utm parameter that is the campaign ID
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Has expiry, 3/2020
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No
To be honest I don't know if this will work. I don't have a way to test this not on production, so it may take some back and forth with QA 😕
Jk let's just pair on this tomorrow @boek?