Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #1298: Adds adjustCampaignId to core ping #5579

Merged
merged 1 commit into from Sep 27, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Sep 25, 2019

To be honest I don't know if this will work. I don't have a way to test this not on production, so it may take some back and forth with QA 😕

Jk let's just pair on this tomorrow @boek?

@sblatz sblatz requested review from a team as code owners September 25, 2019 20:29
@sblatz sblatz added the needs:data-review PR is awaiting a data review label Sep 25, 2019
@sblatz sblatz requested a review from boek September 25, 2019 20:36
@sblatz sblatz force-pushed the new-adjust-campaign-metrics branch 3 times, most recently from 9a32437 to 37ceab3 Compare September 25, 2019 20:50
@sblatz
Copy link
Contributor Author

sblatz commented Sep 25, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • Which marketing campaign the user installed Fenix from
  • Whether or not the user installed Fenix "organically" from the play store
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • They help us track where users install Fenix from which will help inform our future marketing campaigns.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • We currently record Adjust campaign id's at all.
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 03/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude / Adjust
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude, Adjust, and with mobile teams.

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #5579 into master will increase coverage by 0.1%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #5579     +/-   ##
===========================================
+ Coverage     13.96%   14.06%   +0.1%     
- Complexity      308      311      +3     
===========================================
  Files           255      255             
  Lines         10438    10427     -11     
  Branches       1514     1506      -8     
===========================================
+ Hits           1458     1467      +9     
+ Misses         8863     8849     -14     
+ Partials        117      111      -6
Impacted Files Coverage Δ Complexity Δ
...a/fenix/components/metrics/AdjustMetricsService.kt 3.57% <0%> (-0.28%) 1 <0> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt 5.94% <100%> (+0.35%) 3 <0> (ø) ⬇️
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 72.25% <100%> (+0.54%) 15 <0> (ø) ⬇️
...enix/trackingprotection/TrackingProtectionStore.kt 93.93% <0%> (-0.98%) 1% <0%> (ø)
...rotection/TrackingProtectionPanelDialogFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../trackingprotection/TrackingProtectionPanelView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...nix/quickactionsheet/QuickActionSheetController.kt 93.33% <0%> (+18.33%) 0% <0%> (ø) ⬇️
...mozilla/fenix/trackingprotection/TrackerBuckets.kt 57.69% <0%> (+18.56%) 6% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b3ed4...1090f8d. Read the comment docs.

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in metrics.yaml and metrics.md

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Fenix data controls

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Fenix PM Vesta will monitor, and this has an expiry

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 1 for recording the installations source campaign ID

  1. Is the data collection request for default-on or default-off?

Default on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

Adds the utm parameter that is the campaign ID

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Has expiry, 3/2020

  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

@boek boek added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:data-review PR is awaiting a data review labels Sep 26, 2019
@sblatz sblatz merged commit 7f328a6 into mozilla-mobile:master Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants