This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fixes #5225 - Intent receiver cleanup #5613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
added
eng:health
Codecov Report
@@ Coverage Diff @@
## master #5613 +/- ##
============================================
+ Coverage 13.96% 13.97% +<.01%
- Complexity 308 309 +1
============================================
Files 255 257 +2
Lines 10440 10448 +8
Branches 1517 1517
============================================
+ Hits 1458 1460 +2
- Misses 8865 8872 +7
+ Partials 117 116 -1
Continue to review full report at Codecov.
|
NotWoods
force-pushed
the
intent-receiver-cleanup
branch
from
fd9132c
to
e572562
Compare
|
bors r=rocketsroger |
bors bot
pushed a commit
that referenced
this pull request
Oct 18, 2019
5613: Fixes #5225 - Intent receiver cleanup r=rocketsroger a=NotWoods ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture Co-authored-by: Tiger Oakes <toakes@mozilla.com>
Build succeeded
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: