Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #1298: Fixes issue with Adjust campaign not sending through Glean #5896

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Oct 9, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #5896 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5896      +/-   ##
============================================
- Coverage     14.49%   14.35%   -0.14%     
+ Complexity      323      320       -3     
============================================
  Files           272      257      -15     
  Lines         11039    10603     -436     
  Branches       1593     1550      -43     
============================================
- Hits           1600     1522      -78     
+ Misses         9311     8955     -356     
+ Partials        128      126       -2
Impacted Files Coverage Δ Complexity Δ
...a/fenix/components/metrics/AdjustMetricsService.kt 3.57% <0%> (+0.12%) 1 <0> (ø) ⬇️
...main/java/org/mozilla/fenix/components/UseCases.kt 0% <0%> (-90%) 0% <0%> (-1%)
app/src/main/java/org/mozilla/fenix/ext/Session.kt 11.11% <0%> (-79.8%) 0% <0%> (ø)
...rc/main/java/org/mozilla/fenix/ext/BookmarkNode.kt 0% <0%> (-50%) 0% <0%> (ø)
...lla/fenix/customtabs/ExternalAppBrowserActivity.kt 8.69% <0%> (-29.77%) 2% <0%> (-2%)
...pp/src/main/java/org/mozilla/fenix/ext/Fragment.kt 60% <0%> (-20%) 0% <0%> (ø)
...src/main/java/org/mozilla/fenix/components/Core.kt 0% <0%> (-18.06%) 0% <0%> (-1%)
...ava/org/mozilla/fenix/browser/UriOpenedObserver.kt 47.05% <0%> (-12.04%) 3% <0%> (ø)
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 29.16% <0%> (-10.37%) 4% <0%> (ø)
...g/mozilla/fenix/components/TabCollectionStorage.kt 0% <0%> (-10%) 0% <0%> (-1%)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad94d49...7ac3e99. Read the comment docs.

@sblatz sblatz force-pushed the add-adjust branch 3 times, most recently from 1017d31 to 4d164e9 Compare October 28, 2019 20:08
@sblatz sblatz changed the title Add adjust For #1298: Fixes issue with Adjust campaign not sending through Glean Oct 28, 2019
@sblatz sblatz marked this pull request as ready for review October 28, 2019 20:14
@sblatz sblatz requested a review from ekager October 28, 2019 20:14
@sblatz sblatz merged commit 2a358db into mozilla-mobile:master Oct 29, 2019
@severinrudie severinrudie mentioned this pull request Nov 6, 2019
30 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants