Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5959 & #5958: Integrates download feature into Fenix #6368

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Oct 31, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from a team October 31, 2019 21:01
@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #6368 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6368      +/-   ##
============================================
- Coverage     14.69%   14.69%   -0.01%     
  Complexity      328      328              
============================================
  Files           272      272              
  Lines         11035    11041       +6     
  Branches       1591     1591              
============================================
  Hits           1622     1622              
- Misses         9284     9290       +6     
  Partials        129      129
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675fe6a...7d534a0. Read the comment docs.

@sblatz sblatz merged commit e62407e into mozilla-mobile:master Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants