Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4456: Updates total_uri_count upload #6482

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Nov 6, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from liuche November 6, 2019 21:40
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #6482 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6482      +/-   ##
============================================
- Coverage     16.48%   16.47%   -0.01%     
- Complexity      353      354       +1     
============================================
  Files           276      276              
  Lines         11146    11155       +9     
  Branches       1602     1602              
============================================
+ Hits           1837     1838       +1     
- Misses         9155     9163       +8     
  Partials        154      154
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 3.8% <ø> (+0.03%) 2 <0> (ø) ⬇️
...la/fenix/components/metrics/GleanMetricsService.kt 7.77% <0%> (-0.03%) 3 <0> (ø)
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 7.69% <0%> (-0.8%) 7% <0%> (+1%)
.../mozilla/fenix/search/awesomebar/AwesomeBarView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f50e2a...15d946f. Read the comment docs.

@liuche liuche merged commit 284f3cf into mozilla-mobile:master Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants