Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5972 - Fixes bugs when launching in private mode on Android 5 #6702

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

boek
Copy link
Contributor

@boek boek commented Nov 20, 2019

There are some issues on Android 5 using activity-aliases so we took that out. In the process of testing opening new links in private mode we noticed the HomeFragment wasn't getting an onResume call when navigating from the browserFragment back to the homeFragment after opening an intent link. Moving that logic to onStart/onStop fixed it.

@boek boek requested review from sblatz and ekager November 20, 2019 00:25
@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@db02fc6). Click here to learn what that means.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6702   +/-   ##
=========================================
  Coverage          ?   17.19%           
  Complexity        ?      365           
=========================================
  Files             ?      272           
  Lines             ?    10769           
  Branches          ?     1513           
=========================================
  Hits              ?     1852           
  Misses            ?     8765           
  Partials          ?      152
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (?)
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 50% <50%> (ø) 4 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db02fc6...cbd9cdc. Read the comment docs.

@ekager
Copy link
Contributor

ekager commented Nov 21, 2019

Can you clean up ktlint pls :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants