This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #5334: added private custom tab processor #6845
Merged
severinrudie
merged 6 commits into
mozilla-mobile:master
from
severinrudie:5334-add-private-custom-tabs
Dec 6, 2019
Merged
For #5334: added private custom tab processor #6845
severinrudie
merged 6 commits into
mozilla-mobile:master
from
severinrudie:5334-add-private-custom-tabs
Dec 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boek
force-pushed
the
5334-add-private-custom-tabs
branch
from
December 2, 2019 23:14
d04c56a
to
e6e0883
Compare
severinrudie
force-pushed
the
5334-add-private-custom-tabs
branch
from
December 2, 2019 23:47
e6e0883
to
ae2f011
Compare
boek
approved these changes
Dec 2, 2019
severinrudie
force-pushed
the
5334-add-private-custom-tabs
branch
from
December 2, 2019 23:53
ae2f011
to
543fd5d
Compare
Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.
RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.
Codecov Report
@@ Coverage Diff @@
## master #6845 +/- ##
============================================
+ Coverage 17.34% 17.46% +0.11%
- Complexity 392 394 +2
============================================
Files 281 281
Lines 11228 11237 +9
Branches 1547 1551 +4
============================================
+ Hits 1948 1962 +14
+ Misses 9127 9120 -7
- Partials 153 155 +2
Continue to review full report at Codecov.
|
boek
pushed a commit
that referenced
this pull request
Dec 16, 2019
* For #5334: added private custom tab processor * For #5334 - Fixes up IntentReceiverActivity for handling intents * For 5334: update styling for private custom tabbs * For 5334: update tests to account for new processors Note that two are still failing. These appear to be true failures, and will be corrected in a later commit. * For 5334: fixes bug introduced by changes to IntentReceiverActivity RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior. * For 5334: add tests for custom tabs processing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: