Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5334: added private custom tab processor #6845

Merged

Conversation

severinrudie
Copy link
Contributor

@severinrudie severinrudie commented Nov 28, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Screen Shot 2019-12-02 at 3 47 51 PM

@boek boek force-pushed the 5334-add-private-custom-tabs branch from d04c56a to e6e0883 Compare December 2, 2019 23:14
@severinrudie severinrudie marked this pull request as ready for review December 2, 2019 23:49
Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.
RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.
@codecov-io
Copy link

Codecov Report

Merging #6845 into master will increase coverage by 0.11%.
The diff coverage is 64.1%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6845      +/-   ##
============================================
+ Coverage     17.34%   17.46%   +0.11%     
- Complexity      392      394       +2     
============================================
  Files           281      281              
  Lines         11228    11237       +9     
  Branches       1547     1551       +4     
============================================
+ Hits           1948     1962      +14     
+ Misses         9127     9120       -7     
- Partials        153      155       +2
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/mozilla/fenix/theme/ThemeManager.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...lla/fenix/customtabs/ExternalAppBrowserActivity.kt 41.66% <ø> (+3.2%) 4 <0> (ø) ⬇️
.../fenix/browser/browsingmode/BrowsingModeManager.kt 100% <ø> (+33.33%) 0 <0> (ø) ⬇️
.../mozilla/fenix/customtabs/CustomTabsIntegration.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/mozilla/fenix/components/IntentProcessors.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...lla/fenix/customtabs/ExternalAppBrowserFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 71.11% <89.28%> (+12.28%) 5 <0> (-1) ⬇️
...la/fenix/shortcut/NewTabShortcutIntentProcessor.kt 75% <0%> (+16.66%) 5% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7208ce9...d9a0548. Read the comment docs.

@severinrudie severinrudie merged commit 5f393bd into mozilla-mobile:master Dec 6, 2019
@severinrudie severinrudie deleted the 5334-add-private-custom-tabs branch December 6, 2019 18:58
boek pushed a commit that referenced this pull request Dec 16, 2019
* For #5334: added private custom tab processor

* For #5334 - Fixes up IntentReceiverActivity for handling intents

* For 5334: update styling for private custom tabbs

* For 5334: update tests to account for new processors

Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.

* For 5334: fixes bug introduced by changes to IntentReceiverActivity

RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.

* For 5334: add tests for custom tabs processing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants