Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Import strings from android-l10n #7009

Merged

Conversation

mozilla-l10n-automation-bot
Copy link
Collaborator

n/t

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@ekager ekager changed the title Import strings from android-l10n. Import strings from android-l10n Dec 16, 2019
@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #7009 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7009   +/-   ##
=========================================
  Coverage     18.99%   18.99%           
  Complexity      436      436           
=========================================
  Files           291      291           
  Lines         11264    11264           
  Branches       1527     1527           
=========================================
  Hits           2140     2140           
  Misses         8961     8961           
  Partials        163      163

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85673a...8b7241c. Read the comment docs.

@ekager
Copy link
Contributor

ekager commented Dec 16, 2019

@Delphine running into a lint error here. Looks like the substitution character has an extra space included

Error: Incorrect formatting string search_add_custom_engine_error_cannot_reach; missing conversion character in '% s' ? [StringFormatInvalid]
[task 2019-12-16T19:26:45.351Z] Při spojování s „% s“ došlo k chybě

@Delphine
Copy link
Contributor

Seems like Flod already corrected this in Pontoon earlier today: https://pontoon.mozilla.org/cs/android-l10n/mozilla-mobile/fenix/app/src/main/res/values/strings.xml/?search=P%C5%99i+spojov%C3%A1n%C3%AD&string=205613

Please let me know if it still doesn't work now!

@mozilla-l10n-automation-bot mozilla-l10n-automation-bot changed the title Import strings from android-l10n Import strings from android-l10n. Dec 17, 2019
@Pike Pike changed the title Import strings from android-l10n. Import strings from android-l10n Dec 20, 2019
@liuche liuche merged commit a50d855 into mozilla-mobile:master Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants