Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Extract IntentProcessorType to its own file and add tests #7012

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Dec 7, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@NotWoods NotWoods added the eng:health Improve code health label Dec 7, 2019
Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think we can have a better commit message by explicitly saying we refactored IntentProcessorType into its own file and added test for IntentProcessorType.

@NotWoods NotWoods changed the title Move and test IntentProcessorType Extract IntentProcessorType to its own file and add tests Dec 10, 2019
@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #7012 into master will decrease coverage by <.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7012      +/-   ##
============================================
- Coverage     18.72%   18.72%   -0.01%     
- Complexity      423      425       +2     
============================================
  Files           284      283       -1     
  Lines         11207    11173      -34     
  Branches       1530     1527       -3     
============================================
- Hits           2099     2092       -7     
+ Misses         8944     8919      -25     
+ Partials        164      162       -2
Impacted Files Coverage Δ Complexity Δ
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 67.74% <100%> (-3.37%) 5 <0> (ø)
...rg/mozilla/fenix/components/IntentProcessorType.kt 91.66% <91.66%> (ø) 6 <6> (?)
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 8.52% <0%> (-0.43%) 8% <0%> (ø)
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../java/org/mozilla/fenix/settings/LoginsFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...g/mozilla/fenix/perf/HotStartPerformanceMonitor.kt
...rc/main/java/org/mozilla/fenix/perf/Performance.kt
...src/main/java/org/mozilla/fenix/components/Core.kt 17.77% <0%> (+0.19%) 1% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e9200...82a3c9e. Read the comment docs.

@NotWoods NotWoods merged commit 3f7205e into mozilla-mobile:master Dec 10, 2019
@NotWoods NotWoods deleted the move-intent-type branch January 25, 2020 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants