Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5586 - Add telemetry for save logins setting #7767

Merged
merged 1 commit into from Jan 22, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Jan 16, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager
Copy link
Contributor Author

ekager commented Jan 16, 2020

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often do users change their setting to let Fenix save logins?
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • We want to know if users turn off fenix's saving logins feature.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • No, saving logins is a new feature with no existing telemetry
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

Until 09/01/2020

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@ekager ekager added the needs:data-review PR is awaiting a data review label Jan 16, 2020
@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #7767 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7767      +/-   ##
============================================
+ Coverage     19.16%   19.17%   +<.01%     
  Complexity      451      451              
============================================
  Files           301      301              
  Lines         11657    11667      +10     
  Branches       1579     1588       +9     
============================================
+ Hits           2234     2237       +3     
- Misses         9238     9243       +5     
- Partials        185      187       +2
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 7.64% <0%> (-0.51%) 3 <0> (ø)
.../fenix/settings/logins/SaveLoginSettingFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/mozilla/fenix/components/metrics/Metrics.kt 21.65% <0%> (-0.62%) 0 <0> (ø)
.../java/org/mozilla/fenix/search/SearchController.kt 73.91% <0%> (-5.4%) 0% <0%> (ø)
...a/org/mozilla/gecko/search/SearchWidgetProvider.kt 0% <0%> (-1.36%) 0% <0%> (-1%)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 14.89% <0%> (-0.33%) 2% <0%> (ø)
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 100% <0%> (ø) 2% <0%> (ø) ⬇️
.../fenix/settings/account/AccountSettingsFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...zilla/fenix/migration/MigrationProgressActivity.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5164e3...eada3d7. Read the comment docs.

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, under data controls

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 2

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Will check-in at expiry

  9. Does the data collection use a third-party collection tool?
    No

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants