-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Bug 1614287 - part 1: Move Fennec Beta to GitHub releases and to a … #8270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8270 +/- ##
============================================
+ Coverage 18.62% 18.66% +0.03%
+ Complexity 459 452 -7
============================================
Files 319 316 -3
Lines 12728 12379 -349
Branches 1680 1629 -51
============================================
- Hits 2371 2310 -61
+ Misses 10156 9870 -286
+ Partials 201 199 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
def _filter_fennec_nightly(task, parameters): | ||
return task.attributes.get("build-type", "") == "fennec-nightly" | ||
|
||
def _filter_fennec(fennec_type, task, parameters): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ for this refactoring, we can re-use this in beta
and later on in release
as well.
@@ -134,13 +134,10 @@ jobs: | |||
|
|||
fennec-beta: | |||
attributes: | |||
# TODO replace `nightly: true` by `release-type: beta` once the data migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ handy comments from last time! \o/
c6e3e13
to
8ae2471
Compare
@@ -1 +1 @@ | |||
3.1.0-beta.1 | |||
4.0.0-beta.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped this file so that builds coming from the fennec/beta
branch will have a more up-to-date version mozilla-mobile/android-components#5262
…dedicated hook
Follows #7728 up. Depends on mozilla-releng/scriptworker-scripts#144.
Pull Request checklist
After merge
To download an APK when reviewing a PR: