Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1614287 - part 1: Move Fennec Beta to GitHub releases and to a … #8270

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

JohanLorenzo
Copy link
Contributor

…dedicated hook

Follows #7728 up. Depends on mozilla-releng/scriptworker-scripts#144.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #8270 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8270      +/-   ##
============================================
+ Coverage     18.62%   18.66%   +0.03%     
+ Complexity      459      452       -7     
============================================
  Files           319      316       -3     
  Lines         12728    12379     -349     
  Branches       1680     1629      -51     
============================================
- Hits           2371     2310      -61     
+ Misses        10156     9870     -286     
+ Partials        201      199       -2
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 72.22% <0%> (-7.07%) 28% <0%> (ø)
...in/java/org/mozilla/fenix/components/Components.kt 34.09% <0%> (-1.47%) 1% <0%> (ø)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 13.67% <0%> (-0.62%) 3% <0%> (ø)
...nix/components/toolbar/BrowserToolbarController.kt 60.79% <0%> (-0.48%) 0% <0%> (ø)
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 10.95% <0%> (-0.16%) 10% <0%> (ø)
...org/mozilla/fenix/crashes/CrashReporterFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/fenix/settings/DefaultBrowserSettingsFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...lla/fenix/components/toolbar/BrowserToolbarView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...g/mozilla/fenix/shortcut/CreateShortcutFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4582c25...8ae2471. Read the comment docs.

Copy link
Contributor

@MihaiTabara MihaiTabara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

def _filter_fennec_nightly(task, parameters):
return task.attributes.get("build-type", "") == "fennec-nightly"

def _filter_fennec(fennec_type, task, parameters):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for this refactoring, we can re-use this in beta and later on in release as well.

@@ -134,13 +134,10 @@ jobs:

fennec-beta:
attributes:
# TODO replace `nightly: true` by `release-type: beta` once the data migration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ handy comments from last time! \o/

@JohanLorenzo JohanLorenzo changed the title Bug 1612540 - part 1: Move Fennec Beta to GitHub releases and a to a … Bug 1612540 - part 1: Move Fennec Beta to GitHub releases and to a … Feb 11, 2020
@@ -1 +1 @@
3.1.0-beta.1
4.0.0-beta.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped this file so that builds coming from the fennec/beta branch will have a more up-to-date version mozilla-mobile/android-components#5262

@JohanLorenzo JohanLorenzo merged commit de759bb into mozilla-mobile:master Feb 19, 2020
@JohanLorenzo JohanLorenzo deleted the bug-1614287 branch February 19, 2020 14:35
pocmo pushed a commit that referenced this pull request Feb 19, 2020
@JohanLorenzo JohanLorenzo changed the title Bug 1612540 - part 1: Move Fennec Beta to GitHub releases and to a … Bug 1614287 - part 1: Move Fennec Beta to GitHub releases and to a … Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants